From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8CC0C4332D for ; Thu, 19 Mar 2020 20:22:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 997F8206D7 for ; Thu, 19 Mar 2020 20:22:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726936AbgCSUWy (ORCPT ); Thu, 19 Mar 2020 16:22:54 -0400 Received: from correo.us.es ([193.147.175.20]:60058 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726785AbgCSUWy (ORCPT ); Thu, 19 Mar 2020 16:22:54 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 229966CB6A for ; Thu, 19 Mar 2020 21:22:22 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 13022DA7B6 for ; Thu, 19 Mar 2020 21:22:22 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 08634DA38F; Thu, 19 Mar 2020 21:22:22 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3FB8FDA3C3; Thu, 19 Mar 2020 21:22:20 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 19 Mar 2020 21:22:20 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 1B71F42EFB81; Thu, 19 Mar 2020 21:22:20 +0100 (CET) Date: Thu, 19 Mar 2020 21:22:50 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Edward Cree Cc: davem@davemloft.net, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, paulb@mellanox.com Subject: Re: [PATCH net] netfilter: nf_flow_table: populate addr_type mask Message-ID: <20200319202250.gruvkyiobkjwcvho@salvia> References: <7ab81e8a-d1db-6b0c-7f22-fb07e0d0432c@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ab81e8a-d1db-6b0c-7f22-fb07e0d0432c@solarflare.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 19, 2020 at 07:37:21PM +0000, Edward Cree wrote: > nf_flow_rule_match() sets control.addr_type in key, so needs to also set > the corresponding mask. An exact match is wanted, so mask is all ones. Applied, thank you.