From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=TlBx=5F=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 017B1C4332D
	for <netdev@archiver.kernel.org>; Fri, 20 Mar 2020 03:44:02 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id C238D20724
	for <netdev@archiver.kernel.org>; Fri, 20 Mar 2020 03:44:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1584675842;
	bh=W1Re1bei/9+HydLN0RQf26IbOv5FeO7jNrNB4G4r2aI=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=NmOrH3ROAQ6FtbTg1Re1OBPpqq9+ZTBxv7F+PRLsTQrbZ+WuvSi0TAE9VvCUGnuEg
	 9O4fkWC29+YOzDcNvOwgYdgKUDUby8obypRynUtv6sTUUMQGxeG5jTQgzuIAJXnk9W
	 j+iwT6cPfAK15APVmTi0pCzkuXSCr8hyBRxHPRDI=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726809AbgCTDoC (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 19 Mar 2020 23:44:02 -0400
Received: from mail.kernel.org ([198.145.29.99]:44140 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726596AbgCTDoB (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 19 Mar 2020 23:44:01 -0400
Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.1])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 2D83420724;
        Fri, 20 Mar 2020 03:44:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1584675841;
        bh=W1Re1bei/9+HydLN0RQf26IbOv5FeO7jNrNB4G4r2aI=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=dHbgLkesBZWpy/c74O+oRvNbmItM4U/6/Pb5R/MaKW+EJqr9BUAYDK0ZbF/c570jv
         FKhaCaqvEKsMGb+8a1YKvZJEqqKIrtO/E8GdLZ7xrP8NkzG7fTwdPqPETXchuCvZtq
         phFG9T9QaENH3VwnSWICEuw83E4iXhSjQQShqs3Y=
Date:   Thu, 19 Mar 2020 20:43:58 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Shannon Nelson <snelson@pensando.io>
Cc:     netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next 4/6] ionic: ignore eexist on rx filter add
Message-ID: <20200319204358.7e141f1a@kicinski-fedora-PC1C0HJN>
In-Reply-To: <20200320023153.48655-5-snelson@pensando.io>
References: <20200320023153.48655-1-snelson@pensando.io>
        <20200320023153.48655-5-snelson@pensando.io>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Thu, 19 Mar 2020 19:31:51 -0700 Shannon Nelson wrote:
> Don't worry if the rx filter add firmware request fails on
> EEXIST, at least we know the filter is there.  Same for
> the delete request, at least we know it isn't there.
> 
> Fixes: 2a654540be10 ("ionic: Add Rx filter and rx_mode ndo support")
> Signed-off-by: Shannon Nelson <snelson@pensando.io>

Why could the filter be there? Seems like the FW shouldn't have filters
the driver didn't add, could a flush/reset command help to start from
clean state?

Just curious.