netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shannon Nelson <snelson@pensando.io>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: Shannon Nelson <snelson@pensando.io>
Subject: [PATCH net-next 5/6] ionic: clean irq affinity on queue deinit
Date: Thu, 19 Mar 2020 19:31:52 -0700	[thread overview]
Message-ID: <20200320023153.48655-6-snelson@pensando.io> (raw)
In-Reply-To: <20200320023153.48655-1-snelson@pensando.io>

Add a little more cleanup when tearing down the queues.

Fixes: 1d062b7b6f64 ("ionic: Add basic adminq support")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
---
 drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
index ea44f510cb76..490f79c82bf1 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
@@ -275,8 +275,10 @@ static void ionic_lif_qcq_deinit(struct ionic_lif *lif, struct ionic_qcq *qcq)
 	if (qcq->flags & IONIC_QCQ_F_INTR) {
 		ionic_intr_mask(idev->intr_ctrl, qcq->intr.index,
 				IONIC_INTR_MASK_SET);
+		irq_set_affinity_hint(qcq->intr.vector, NULL);
 		devm_free_irq(dev, qcq->intr.vector, &qcq->napi);
 		netif_napi_del(&qcq->napi);
+		qcq->intr.vector = 0;
 	}
 
 	qcq->flags &= ~IONIC_QCQ_F_INITED;
-- 
2.17.1


  parent reply	other threads:[~2020-03-20  2:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  2:31 [PATCH net-next 0/6] ionic error recovery fixes Shannon Nelson
2020-03-20  2:31 ` [PATCH net-next 1/6] ionic: add timeout error checking for queue disable Shannon Nelson
2020-03-20  2:31 ` [PATCH net-next 2/6] ionic: leave dev cmd request contents alone on FW timeout Shannon Nelson
2020-03-20  2:31 ` [PATCH net-next 3/6] ionic: only save good lif dentry Shannon Nelson
2020-03-20  2:31 ` [PATCH net-next 4/6] ionic: ignore eexist on rx filter add Shannon Nelson
2020-03-20  3:43   ` Jakub Kicinski
2020-03-20  5:21     ` Shannon Nelson
2020-03-20 17:16       ` Jakub Kicinski
2020-03-20  2:31 ` Shannon Nelson [this message]
2020-03-20  2:31 ` [PATCH net-next 6/6] ionic: check for NULL structs on teardown Shannon Nelson
2020-03-20  3:46 ` [PATCH net-next 0/6] ionic error recovery fixes Jakub Kicinski
2020-03-20  5:21   ` Shannon Nelson
2020-03-22  2:56 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320023153.48655-6-snelson@pensando.io \
    --to=snelson@pensando.io \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).