From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4736AC4332B for ; Fri, 20 Mar 2020 17:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12F0320709 for ; Fri, 20 Mar 2020 17:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584724594; bh=pA35YsYyEzh7J5AFrQ+55ycCcMb0kGjl2SvJtIqc/vE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ySnPG8NNPfQJdZblE7dkaKM/u3NFHlJTw1yWJXoUkkfXFvgzmK29eteqREUuxh2ds XNkN4gmB3cBNd6neuCJrO71g9HfuxyJjOWSe9fykImciBzhhZKGMKT4z90f4Er0dkR XTuGu3rVJY9at/Scs6KsvL+jWjP1b5ZCGwzoUm+8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgCTRQd (ORCPT ); Fri, 20 Mar 2020 13:16:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:47284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726867AbgCTRQd (ORCPT ); Fri, 20 Mar 2020 13:16:33 -0400 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69DD320709; Fri, 20 Mar 2020 17:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584724592; bh=pA35YsYyEzh7J5AFrQ+55ycCcMb0kGjl2SvJtIqc/vE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=elcBt5UVGQVmY4n+ynRa71jo2zh+TtsQGqha1xdIrb3RDS54qCYOVCAkgq2hN2XCW s5fezh1wVbG/1IRw5bKOlMS2XgzWB+gfy6LHKTdQjp4cvFrlZgloAO1zjPa8DozsLt /Jr8wKN+KMVvsqpxe90UFnJ8ZJA+g03pzP6lghr4= Date: Fri, 20 Mar 2020 10:16:30 -0700 From: Jakub Kicinski To: Shannon Nelson Cc: netdev@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH net-next 4/6] ionic: ignore eexist on rx filter add Message-ID: <20200320101630.13d80223@kicinski-fedora-PC1C0HJN> In-Reply-To: References: <20200320023153.48655-1-snelson@pensando.io> <20200320023153.48655-5-snelson@pensando.io> <20200319204358.7e141f1a@kicinski-fedora-PC1C0HJN> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 19 Mar 2020 22:21:35 -0700 Shannon Nelson wrote: > On 3/19/20 8:43 PM, Jakub Kicinski wrote: > > On Thu, 19 Mar 2020 19:31:51 -0700 Shannon Nelson wrote: > >> Don't worry if the rx filter add firmware request fails on > >> EEXIST, at least we know the filter is there. Same for > >> the delete request, at least we know it isn't there. > >> > >> Fixes: 2a654540be10 ("ionic: Add Rx filter and rx_mode ndo support") > >> Signed-off-by: Shannon Nelson > > Why could the filter be there? Seems like the FW shouldn't have filters > > the driver didn't add, could a flush/reset command help to start from > > clean state? > > > > Just curious. > Because there are use cases where the device is configured by an > external centralized agent and may have already stuck the appropriate > filters into the its list. Thanks, seems a little leaky for the host to be able to probe the state installed by the agent, but it does explain the need.