From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ED73C4332B for ; Fri, 20 Mar 2020 21:33:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DE6220767 for ; Fri, 20 Mar 2020 21:33:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fomichev-me.20150623.gappssmtp.com header.i=@fomichev-me.20150623.gappssmtp.com header.b="ZngJrysM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727122AbgCTVdT (ORCPT ); Fri, 20 Mar 2020 17:33:19 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:53498 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726783AbgCTVdS (ORCPT ); Fri, 20 Mar 2020 17:33:18 -0400 Received: by mail-pj1-f66.google.com with SMTP id l36so3067710pjb.3 for ; Fri, 20 Mar 2020 14:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fomichev-me.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TU2T6ZpLINjsN0NPDwk9LFYRhL6nv6T9Pj1rk4Fvgws=; b=ZngJrysM1xXorW7zcL8RRdLTgvsh8baMVjy2WjSb3Tlqu3Y3WfBqYiJxkPtGhlwMFw gcyG9gv/4jqR3qsXlAvzSdy1kx1VguJoz+6LdMZruz9WvUfBeYGWTzPWCA4RG6MCsPXz Wdr7Y1jqdfClPrw6c4o5qc/Wv3nxDkSGyt4tmLYUFD3Io8xrUOuBcc53VuFkjvNE4lqA iUGTKSlcz/f1ZUV52bt3+NjUCU1j/f2Yx+hPQYKu8HEaCq7juNap2mF4V66DtaY//wZQ ePx0srok7JGhH/Y6W8PToAW63KED8yNX6MDZHWePdBMNbrXWGxsnaen7Kh1wQzuwb7ux RHDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TU2T6ZpLINjsN0NPDwk9LFYRhL6nv6T9Pj1rk4Fvgws=; b=o2xkxkA3+QggxLssIa/ot5qCnaANMg9ISyiTFxaNXL7hTgMOxdtPZULzgXlxk8QK+8 Gd69Syzc7jWG7jAMKFSXP7R8jQWKK6zaqz24jmIw9fpTdZ6pPWeLIJhhGeRZLIf98shf BHkRGpg7XW5PEvi0DOiuE5T5cmPR8WY1yEUyTd6umMjqf5sLBzex/TZfMY8w1wxQxOAx 9Ao35BSCMmOu/D02qjz0iVfMTB3oFrI1F9vtRt2FAk3MCa/8HYd4LLEtjt9VnigAaQam 0dsD7vKX2sAFsdCuvMygTDZlprl3u9W6sRuCsZzLcIGKFEu+YMSOBxHaa+ak/WdKhayz FgqQ== X-Gm-Message-State: ANhLgQ0BKUcLMFRx3I6yKnSgvc6Ov6z/Dxk2t2qoUaGStfRx8kox5Slh GM2H5rNLEE3+9Lkmm+4fDfj7NfZncOk= X-Google-Smtp-Source: ADFU+vvnWAei4cQJJYAi95fr3AY6Ha6YpQA+nmxexdMSFSnYsOJojq6pn1eKeR48kRER+fOR67vbGQ== X-Received: by 2002:a17:902:8a81:: with SMTP id p1mr10353607plo.284.1584739997755; Fri, 20 Mar 2020 14:33:17 -0700 (PDT) Received: from localhost ([2601:646:8f00:18d9:d0fa:7a4b:764f:de48]) by smtp.gmail.com with ESMTPSA id l67sm5756255pjb.23.2020.03.20.14.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 14:33:17 -0700 (PDT) Date: Fri, 20 Mar 2020 14:33:16 -0700 From: Stanislav Fomichev To: Andrii Nakryiko Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com, daniel@iogearbox.net, andrii.nakryiko@gmail.com, kernel-team@fb.com Subject: Re: [PATCH bpf-next 3/6] bpf: implement bpf_link-based cgroup BPF program attachment Message-ID: <20200320213316.GA2708166@mini-arch.hsd1.ca.comcast.net> References: <20200320203615.1519013-1-andriin@fb.com> <20200320203615.1519013-4-andriin@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320203615.1519013-4-andriin@fb.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/20, Andrii Nakryiko wrote: > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 5d01c5c7e598..fad9f79bb8f1 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -111,6 +111,7 @@ enum bpf_cmd { > BPF_MAP_LOOKUP_AND_DELETE_BATCH, > BPF_MAP_UPDATE_BATCH, > BPF_MAP_DELETE_BATCH, [..] > + BPF_LINK_CREATE, Curious, why did you decide to add new command versus reusing existing BPF_PROG_ATTACH/BPF_PROG_DETACH pair? Can we have a new flag like BPF_F_NOT_OWNED that we can set when calling BPF_PROG_ATTACH to trigger all these new bpf_link properties (like cgroup not holding an extra ref)?