From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD15AC41621 for ; Tue, 24 Mar 2020 03:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FCCD20714 for ; Tue, 24 Mar 2020 03:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727261AbgCXD5q (ORCPT ); Mon, 23 Mar 2020 23:57:46 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55860 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727050AbgCXD5q (ORCPT ); Mon, 23 Mar 2020 23:57:46 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 594D115513618; Mon, 23 Mar 2020 20:57:45 -0700 (PDT) Date: Mon, 23 Mar 2020 20:57:44 -0700 (PDT) Message-Id: <20200323.205744.1206748041598234398.davem@davemloft.net> To: natechancellor@gmail.com Cc: jiri@mellanox.com, idosch@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mlxsw: spectrum_cnt: Fix 64-bit division in mlxsw_sp_counter_resources_register From: David Miller In-Reply-To: <20200320021638.1916-1-natechancellor@gmail.com> References: <20200320021638.1916-1-natechancellor@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 23 Mar 2020 20:57:45 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Nathan Chancellor Date: Thu, 19 Mar 2020 19:16:38 -0700 > When building arm32 allyesconfig: > > ld.lld: error: undefined symbol: __aeabi_uldivmod >>>> referenced by spectrum_cnt.c >>>> net/ethernet/mellanox/mlxsw/spectrum_cnt.o:(mlxsw_sp_counter_resources_register) in archive drivers/built-in.a >>>> did you mean: __aeabi_uidivmod >>>> defined in: arch/arm/lib/lib.a(lib1funcs.o) > > pool_size and bank_size are u64; use div64_u64 so that 32-bit platforms > do not error. > > Fixes: ab8c4cc60420 ("mlxsw: spectrum_cnt: Move config validation along with resource register") > Signed-off-by: Nathan Chancellor Applied to net-next. Please be clear about the intended target GIT tree for your changes in the Subject line in the future, thank you.