From: David Miller <davem@davemloft.net>
To: olteanv@gmail.com
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
vivien.didelot@gmail.com
Subject: Re: [PATCH net] net: dsa: tag_8021q: replace dsa_8021q_remove_header with __skb_vlan_pop
Date: Tue, 24 Mar 2020 16:19:32 -0700 (PDT) [thread overview]
Message-ID: <20200324.161932.2119088651104512505.davem@davemloft.net> (raw)
In-Reply-To: <20200324094534.29769-1-olteanv@gmail.com>
From: Vladimir Oltean <olteanv@gmail.com>
Date: Tue, 24 Mar 2020 11:45:34 +0200
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> Not only did this wheel did not need reinventing, but there is also
> an issue with it: It doesn't remove the VLAN header in a way that
> preserves the L2 payload checksum when that is being provided by the DSA
> master hw. It should recalculate checksum both for the push, before
> removing the header, and for the pull afterwards. But the current
> implementation is quite dizzying, with pulls followed immediately
> afterwards by pushes, the memmove is done before the push, etc. This
> makes a DSA master with RX checksumming offload to print stack traces
> with the infamous 'hw csum failure' message.
>
> So remove the dsa_8021q_remove_header function and replace it with
> something that actually works with inet checksumming.
>
> Fixes: d461933638ae ("net: dsa: tag_8021q: Create helper function for removing VLAN header")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2020-03-24 23:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 9:45 [PATCH net] net: dsa: tag_8021q: replace dsa_8021q_remove_header with __skb_vlan_pop Vladimir Oltean
2020-03-24 23:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324.161932.2119088651104512505.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).