From: David Miller <davem@davemloft.net>
To: vladyslavt@mellanox.com
Cc: netdev@vger.kernel.org, maximmi@mellanox.com, mkubecek@suse.cz,
moshe@mellanox.com
Subject: Re: [PATCH net-next] ethtool: fix incorrect tx-checksumming settings reporting
Date: Tue, 24 Mar 2020 16:25:36 -0700 (PDT) [thread overview]
Message-ID: <20200324.162536.1931215402668902440.davem@davemloft.net> (raw)
In-Reply-To: <20200324115708.31186-1-vladyslavt@mellanox.com>
From: Vladyslav Tarasiuk <vladyslavt@mellanox.com>
Date: Tue, 24 Mar 2020 13:57:08 +0200
> Currently, ethtool feature mask for checksum command is ORed with
> NETIF_F_FCOE_CRC_BIT, which is bit's position number, instead of the
> actual feature bit - NETIF_F_FCOE_CRC.
>
> The invalid bitmask here might affect unrelated features when toggling
> TX checksumming. For example, TX checksumming is always mistakenly
> reported as enabled on the netdevs tested (mlx5, virtio_net).
>
> Fixes: f70bb06563ed ("ethtool: update mapping of features to legacy ioctl requests")
> Signed-off-by: Vladyslav Tarasiuk <vladyslavt@mellanox.com>
Applied, thanks.
prev parent reply other threads:[~2020-03-24 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 11:57 [PATCH net-next] ethtool: fix incorrect tx-checksumming settings reporting Vladyslav Tarasiuk
2020-03-24 13:34 ` Michal Kubecek
2020-03-24 23:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324.162536.1931215402668902440.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=maximmi@mellanox.com \
--cc=mkubecek@suse.cz \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=vladyslavt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).