From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D848C10DCE for ; Tue, 24 Mar 2020 23:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C69B20409 for ; Tue, 24 Mar 2020 23:25:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727054AbgCXXZh (ORCPT ); Tue, 24 Mar 2020 19:25:37 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37874 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726643AbgCXXZh (ORCPT ); Tue, 24 Mar 2020 19:25:37 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E770F159F5293; Tue, 24 Mar 2020 16:25:36 -0700 (PDT) Date: Tue, 24 Mar 2020 16:25:36 -0700 (PDT) Message-Id: <20200324.162536.1931215402668902440.davem@davemloft.net> To: vladyslavt@mellanox.com Cc: netdev@vger.kernel.org, maximmi@mellanox.com, mkubecek@suse.cz, moshe@mellanox.com Subject: Re: [PATCH net-next] ethtool: fix incorrect tx-checksumming settings reporting From: David Miller In-Reply-To: <20200324115708.31186-1-vladyslavt@mellanox.com> References: <20200324115708.31186-1-vladyslavt@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Mar 2020 16:25:37 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vladyslav Tarasiuk Date: Tue, 24 Mar 2020 13:57:08 +0200 > Currently, ethtool feature mask for checksum command is ORed with > NETIF_F_FCOE_CRC_BIT, which is bit's position number, instead of the > actual feature bit - NETIF_F_FCOE_CRC. > > The invalid bitmask here might affect unrelated features when toggling > TX checksumming. For example, TX checksumming is always mistakenly > reported as enabled on the netdevs tested (mlx5, virtio_net). > > Fixes: f70bb06563ed ("ethtool: update mapping of features to legacy ioctl requests") > Signed-off-by: Vladyslav Tarasiuk Applied, thanks.