From: David Miller <davem@davemloft.net>
To: antoine.tenart@bootlin.com
Cc: andrew@lunn.ch, olteanv@gmail.com, netdev@vger.kernel.org,
f.fainelli@gmail.com, hkallweit1@gmail.com
Subject: Re: [PATCH net-next] net: phy: mscc: consolidate a common RGMII delay implementation
Date: Tue, 24 Mar 2020 16:36:51 -0700 (PDT) [thread overview]
Message-ID: <20200324.163651.1067037521170220223.davem@davemloft.net> (raw)
In-Reply-To: <158506137648.157373.6196697912192436523@kwain>
From: Antoine Tenart <antoine.tenart@bootlin.com>
Date: Tue, 24 Mar 2020 15:49:37 +0100
> Hi Vladimir,
>
> Quoting Andrew Lunn (2020-03-24 15:18:29)
>> On Tue, Mar 24, 2020 at 04:13:58PM +0200, Vladimir Oltean wrote:
>> > From: Vladimir Oltean <vladimir.oltean@nxp.com>
>> >
>> > It looks like the VSC8584 PHY driver is rolling its own RGMII delay
>> > configuration code, despite the fact that the logic is mostly the same.
>> >
>> > In fact only the register layout and position for the RGMII controls has
>> > changed. So we need to adapt and parameterize the PHY-dependent bit
>> > fields when calling the new generic function.
>> >
>> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>>
>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Tested-by: Antoine Tenart <antoine.tenart@bootlin.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2020-03-24 23:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 14:13 [PATCH net-next] net: phy: mscc: consolidate a common RGMII delay implementation Vladimir Oltean
2020-03-24 14:18 ` Andrew Lunn
2020-03-24 14:49 ` Antoine Tenart
2020-03-24 14:51 ` Vladimir Oltean
2020-03-24 23:36 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-24 12:48 Vladimir Oltean
2020-03-24 13:40 ` Andrew Lunn
2020-03-24 14:13 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324.163651.1067037521170220223.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).