From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 748C7C10DCE for ; Tue, 24 Mar 2020 23:36:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5534320724 for ; Tue, 24 Mar 2020 23:36:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727134AbgCXXgx (ORCPT ); Tue, 24 Mar 2020 19:36:53 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37964 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbgCXXgx (ORCPT ); Tue, 24 Mar 2020 19:36:53 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 78531159F5F6C; Tue, 24 Mar 2020 16:36:52 -0700 (PDT) Date: Tue, 24 Mar 2020 16:36:51 -0700 (PDT) Message-Id: <20200324.163651.1067037521170220223.davem@davemloft.net> To: antoine.tenart@bootlin.com Cc: andrew@lunn.ch, olteanv@gmail.com, netdev@vger.kernel.org, f.fainelli@gmail.com, hkallweit1@gmail.com Subject: Re: [PATCH net-next] net: phy: mscc: consolidate a common RGMII delay implementation From: David Miller In-Reply-To: <158506137648.157373.6196697912192436523@kwain> References: <20200324141358.4341-1-olteanv@gmail.com> <20200324141829.GB14512@lunn.ch> <158506137648.157373.6196697912192436523@kwain> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 24 Mar 2020 16:36:52 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Antoine Tenart Date: Tue, 24 Mar 2020 15:49:37 +0100 > Hi Vladimir, > > Quoting Andrew Lunn (2020-03-24 15:18:29) >> On Tue, Mar 24, 2020 at 04:13:58PM +0200, Vladimir Oltean wrote: >> > From: Vladimir Oltean >> > >> > It looks like the VSC8584 PHY driver is rolling its own RGMII delay >> > configuration code, despite the fact that the logic is mostly the same. >> > >> > In fact only the register layout and position for the RGMII controls has >> > changed. So we need to adapt and parameterize the PHY-dependent bit >> > fields when calling the new generic function. >> > >> > Signed-off-by: Vladimir Oltean >> >> Reviewed-by: Andrew Lunn > > Tested-by: Antoine Tenart Applied, thanks everyone.