From: Julian Wiedmann <jwi@linux.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Ursula Braun <ubraun@linux.ibm.com>,
Julian Wiedmann <jwi@linux.ibm.com>
Subject: [PATCH v2 net-next 11/11] s390/qeth: modernize two list helpers
Date: Wed, 25 Mar 2020 10:35:07 +0100 [thread overview]
Message-ID: <20200325093507.20831-12-jwi@linux.ibm.com> (raw)
In-Reply-To: <20200325093507.20831-1-jwi@linux.ibm.com>
Replace list_for_each() with list_for_each_entry(), and
list_entry(head.next) with list_first_entry().
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
drivers/s390/net/qeth_core_main.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index 8713f1b821c1..d06d9f847388 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -2629,15 +2629,13 @@ static void qeth_initialize_working_pool_list(struct qeth_card *card)
static struct qeth_buffer_pool_entry *qeth_find_free_buffer_pool_entry(
struct qeth_card *card)
{
- struct list_head *plh;
struct qeth_buffer_pool_entry *entry;
int i, free;
if (list_empty(&card->qdio.in_buf_pool.entry_list))
return NULL;
- list_for_each(plh, &card->qdio.in_buf_pool.entry_list) {
- entry = list_entry(plh, struct qeth_buffer_pool_entry, list);
+ list_for_each_entry(entry, &card->qdio.in_buf_pool.entry_list, list) {
free = 1;
for (i = 0; i < QETH_MAX_BUFFER_ELEMENTS(card); ++i) {
if (page_count(entry->elements[i]) > 1) {
@@ -2652,8 +2650,8 @@ static struct qeth_buffer_pool_entry *qeth_find_free_buffer_pool_entry(
}
/* no free buffer in pool so take first one and swap pages */
- entry = list_entry(card->qdio.in_buf_pool.entry_list.next,
- struct qeth_buffer_pool_entry, list);
+ entry = list_first_entry(&card->qdio.in_buf_pool.entry_list,
+ struct qeth_buffer_pool_entry, list);
for (i = 0; i < QETH_MAX_BUFFER_ELEMENTS(card); ++i) {
if (page_count(entry->elements[i]) > 1) {
struct page *page = dev_alloc_page();
--
2.17.1
next prev parent reply other threads:[~2020-03-25 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 9:34 [PATCH v2 net-next 00/11] s390/qeth: updates 2020-03-25 Julian Wiedmann
2020-03-25 9:34 ` [PATCH v2 net-next 01/11] s390/qeth: simplify RX buffer tracking Julian Wiedmann
2020-03-25 9:34 ` [PATCH v2 net-next 02/11] s390/qeth: split out RX poll code Julian Wiedmann
2020-03-25 9:34 ` [PATCH v2 net-next 03/11] s390/qeth: remove redundant if-clause in " Julian Wiedmann
2020-03-25 9:35 ` [PATCH v2 net-next 04/11] s390/qdio: extend polling support to multiple queues Julian Wiedmann
2020-03-25 9:35 ` [PATCH v2 net-next 05/11] s390/qeth: simplify L3 dev_id logic Julian Wiedmann
2020-03-25 9:35 ` [PATCH v2 net-next 06/11] s390/qeth: clean up the mac_bits Julian Wiedmann
2020-03-25 9:35 ` [PATCH v2 net-next 07/11] s390/qeth: collect more TX statistics Julian Wiedmann
2020-03-25 9:35 ` [PATCH v2 net-next 08/11] s390/qeth: add TX IRQ coalescing support for IQD devices Julian Wiedmann
2020-03-25 9:35 ` [PATCH v2 net-next 09/11] s390/qeth: fine-tune MAC Address-related errnos Julian Wiedmann
2020-03-25 9:35 ` [PATCH v2 net-next 10/11] s390/qeth: keep track of fixed prio-queue configuration Julian Wiedmann
2020-03-25 9:35 ` Julian Wiedmann [this message]
2020-03-25 19:07 ` [PATCH v2 net-next 00/11] s390/qeth: updates 2020-03-25 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325093507.20831-12-jwi@linux.ibm.com \
--to=jwi@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).