netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Igor Russkikh <irusskikh@marvell.com>
To: <netdev@vger.kernel.org>
Cc: Mark Starovoytov <mstarovoitov@marvell.com>,
	Sabrina Dubroca <sd@queasysnail.net>,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	"Igor Russkikh" <irusskikh@marvell.com>
Subject: [PATCH v2 net-next 17/17] net: atlantic: add XPN handling
Date: Wed, 25 Mar 2020 15:52:46 +0300	[thread overview]
Message-ID: <20200325125246.987-18-irusskikh@marvell.com> (raw)
In-Reply-To: <20200325125246.987-1-irusskikh@marvell.com>

From: Mark Starovoytov <mstarovoitov@marvell.com>

This patch adds XPN handling.
Our driver doesn't support XPN, but we should still update a couple
of places in the code, because the size of 'next_pn' field has
changed.

Signed-off-by: Mark Starovoytov <mstarovoitov@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
 drivers/net/ethernet/aquantia/atlantic/aq_macsec.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_macsec.c b/drivers/net/ethernet/aquantia/atlantic/aq_macsec.c
index 4bd283ba0d56..0b3e234a54aa 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_macsec.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_macsec.c
@@ -452,6 +452,9 @@ static int aq_mdo_add_secy(struct macsec_context *ctx)
 	u32 txsc_idx;
 	int ret = 0;
 
+	if (secy->xpn)
+		return -EOPNOTSUPP;
+
 	sc_sa = sc_sa_from_num_an(MACSEC_NUM_AN);
 	if (sc_sa == aq_macsec_sa_sc_not_used)
 		return -EINVAL;
@@ -556,6 +559,7 @@ static int aq_update_txsa(struct aq_nic_s *nic, const unsigned int sc_idx,
 			  const struct macsec_tx_sa *tx_sa,
 			  const unsigned char *key, const unsigned char an)
 {
+	const u32 next_pn = tx_sa->next_pn_halves.lower;
 	struct aq_mss_egress_sakey_record key_rec;
 	const unsigned int sa_idx = sc_idx | an;
 	struct aq_mss_egress_sa_record sa_rec;
@@ -565,7 +569,7 @@ static int aq_update_txsa(struct aq_nic_s *nic, const unsigned int sc_idx,
 	memset(&sa_rec, 0, sizeof(sa_rec));
 	sa_rec.valid = tx_sa->active;
 	sa_rec.fresh = 1;
-	sa_rec.next_pn = tx_sa->next_pn;
+	sa_rec.next_pn = next_pn;
 
 	ret = aq_mss_set_egress_sa_record(hw, &sa_rec, sa_idx);
 	if (ret)
@@ -889,6 +893,7 @@ static int aq_update_rxsa(struct aq_nic_s *nic, const unsigned int sc_idx,
 			  const unsigned char *key, const unsigned char an)
 {
 	struct aq_mss_ingress_sakey_record sa_key_record;
+	const u32 next_pn = rx_sa->next_pn_halves.lower;
 	struct aq_mss_ingress_sa_record sa_record;
 	struct aq_hw_s *hw = nic->aq_hw;
 	const int sa_idx = sc_idx | an;
@@ -897,7 +902,7 @@ static int aq_update_rxsa(struct aq_nic_s *nic, const unsigned int sc_idx,
 	memset(&sa_record, 0, sizeof(sa_record));
 	sa_record.valid = rx_sa->active;
 	sa_record.fresh = 1;
-	sa_record.next_pn = rx_sa->next_pn;
+	sa_record.next_pn = next_pn;
 
 	ret = aq_mss_set_ingress_sa_record(hw, &sa_record, sa_idx);
 	if (ret)
-- 
2.17.1


  parent reply	other threads:[~2020-03-25 12:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 12:52 [PATCH v2 net-next 00/17] net: atlantic: MACSec support for AQC devices Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 01/17] net: introduce the MACSEC netdev feature Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 02/17] net: add a reference to MACsec ops in net_device Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 03/17] net: macsec: allow to reference a netdev from a MACsec context Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 04/17] net: macsec: add support for offloading to the MAC Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 05/17] net: macsec: init secy pointer in macsec_context Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 06/17] net: macsec: allow multiple macsec devices with offload Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 07/17] net: macsec: support multicast/broadcast when offloading Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 08/17] net: macsec: add support for getting offloaded stats Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 09/17] net: macsec: report real_dev features when HW offloading is enabled Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 10/17] net: atlantic: MACSec offload skeleton Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 11/17] net: atlantic: MACSec egress offload HW bindings Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 12/17] net: atlantic: MACSec egress offload implementation Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 13/17] net: atlantic: MACSec ingress offload HW bindings Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 14/17] net: atlantic: MACSec ingress offload implementation Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 15/17] net: atlantic: MACSec offload statistics HW bindings Igor Russkikh
2020-03-25 12:52 ` [PATCH v2 net-next 16/17] net: atlantic: MACSec offload statistics implementation Igor Russkikh
2020-03-25 12:52 ` Igor Russkikh [this message]
2020-03-27  3:18 ` [PATCH v2 net-next 00/17] net: atlantic: MACSec support for AQC devices David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200325125246.987-18-irusskikh@marvell.com \
    --to=irusskikh@marvell.com \
    --cc=antoine.tenart@bootlin.com \
    --cc=mstarovoitov@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).