From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, linux@armlinux.org.uk,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: don't touch suspended flag if there's no suspend/resume callback
Date: Thu, 26 Mar 2020 20:30:08 -0700 (PDT) [thread overview]
Message-ID: <20200326.203008.725583123135834564.davem@davemloft.net> (raw)
In-Reply-To: <313dae57-8c05-a82b-ea87-a0822e9462f0@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 26 Mar 2020 18:58:24 +0100
> So far we set phydev->suspended to true in phy_suspend() even if the
> PHY driver doesn't implement the suspend callback. This applies
> accordingly for the resume path. The current behavior doesn't cause
> any issue I'd be aware of, but it's not logical and misleading,
> especially considering the description of the flag:
> "suspended: Set to true if this phy has been suspended successfully"
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2020-03-27 3:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 17:58 [PATCH net-next] net: phy: don't touch suspended flag if there's no suspend/resume callback Heiner Kallweit
2020-03-26 23:38 ` Andrew Lunn
2020-03-26 23:42 ` Florian Fainelli
2020-03-27 3:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326.203008.725583123135834564.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).