Re: [PATCH net-next 1/2] devlink: Implicitly set auto recover flag when registering health reporter

Jakub Kicinski
2020-03-25T18:33:40Z

On Wed, 25 Mar 2020 15:26:23 +0200 Eran Ben Elisha wrote:
> When health reporter is registered to devlink, devlink will implicitly set
> auto recover if and only if the reporter has a recover method. No reason
> to explicitly get the auto recover flag from the driver.
>
> Remove this flag from all drivers that called
> devlink_health_reporter_create.
>
> Yet, administrator can unset auto recover via netlink command as prior to
> this patch.
>
> Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>

It would have been useful to say that all the cases where auto-recovery
was disabled don't have the recover method.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>