From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA0FC2D0E5 for ; Thu, 26 Mar 2020 18:37:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 311832074D for ; Thu, 26 Mar 2020 18:37:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728629AbgCZShs (ORCPT ); Thu, 26 Mar 2020 14:37:48 -0400 Received: from mga09.intel.com ([134.134.136.24]:43777 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbgCZShg (ORCPT ); Thu, 26 Mar 2020 14:37:36 -0400 IronPort-SDR: ff9MIxEONpuLEGR6vjunoWpn1TpBu5ScTLlH7KqNYnaCI6344JGJXAA+8w38DGy0hoNZf+nghh G3GXA6c8i0DQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 11:37:23 -0700 IronPort-SDR: vxMzHNOkLU62P6ri6Zkd9WiMAm2kES8VZaHbOFvTOH8Hljmno8OMjr0UH1bBAgzw/hs/lriF6i sZ4/BjBdeACA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,309,1580803200"; d="scan'208";a="358241624" Received: from jekeller-desk.amr.corp.intel.com ([10.166.241.33]) by fmsmga001.fm.intel.com with ESMTP; 26 Mar 2020 11:37:23 -0700 From: Jacob Keller To: netdev@vger.kernel.org Cc: Jakub Kicinski , Jiri Pirko , Jacob Keller , Jiri Pirko Subject: [PATCH net-next v3 05/11] devlink: use -ENOSPC to indicate no more room for snapshots Date: Thu, 26 Mar 2020 11:37:12 -0700 Message-Id: <20200326183718.2384349-6-jacob.e.keller@intel.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200326183718.2384349-1-jacob.e.keller@intel.com> References: <20200326183718.2384349-1-jacob.e.keller@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The devlink_region_snapshot_create function returns -ENOMEM when the maximum number of snapshots has been reached. This is confusing because it is not an issue of being out of memory. Change this to use -ENOSPC instead. Reported-by: Jiri Pirko Signed-off-by: Jacob Keller Reviewed-by: Jiri Pirko --- Changes since v1: * Introduced this patch net/core/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 620e9d07ac85..8c2c4bc009bb 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -3793,7 +3793,7 @@ __devlink_region_snapshot_create(struct devlink_region *region, /* check if region can hold one more snapshot */ if (region->cur_snapshots == region->max_snapshots) - return -ENOMEM; + return -ENOSPC; if (devlink_region_snapshot_get_by_id(region, snapshot_id)) return -EEXIST; -- 2.24.1