* [PATCH net-next v2] net: phy: probe PHY drivers synchronously
@ 2020-03-27 0:00 Heiner Kallweit
2020-03-27 0:02 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Heiner Kallweit @ 2020-03-27 0:00 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Russell King - ARM Linux,
David Miller
Cc: netdev@vger.kernel.org
If we have scenarios like
mdiobus_register()
-> loads PHY driver module(s)
-> registers PHY driver(s)
-> may schedule async probe
phydev = mdiobus_get_phy()
<phydev action involving PHY driver>
or
phydev = phy_device_create()
-> loads PHY driver module
-> registers PHY driver
-> may schedule async probe
<phydev action involving PHY driver>
then we expect the PHY driver to be bound to the phydev when triggering
the action. This may not be the case in case of asynchronous probing.
Therefore ensure that PHY drivers are probed synchronously.
Default still is sync probing, except async probing is explicitly
requested. I saw some comments that the intention is to promote
async probing for more parallelism in boot process and want to be
prepared for the case that the default is changed to async probing.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/phy/phy_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index d6024b678..ac2784192 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -2575,6 +2575,7 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner)
new_driver->mdiodrv.driver.probe = phy_probe;
new_driver->mdiodrv.driver.remove = phy_remove;
new_driver->mdiodrv.driver.owner = owner;
+ new_driver->mdiodrv.driver.probe_type = PROBE_FORCE_SYNCHRONOUS;
retval = driver_register(&new_driver->mdiodrv.driver);
if (retval) {
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next v2] net: phy: probe PHY drivers synchronously
2020-03-27 0:00 [PATCH net-next v2] net: phy: probe PHY drivers synchronously Heiner Kallweit
@ 2020-03-27 0:02 ` Florian Fainelli
2020-03-27 0:09 ` Andrew Lunn
2020-03-27 2:43 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-03-27 0:02 UTC (permalink / raw)
To: Heiner Kallweit, Andrew Lunn, Russell King - ARM Linux,
David Miller
Cc: netdev@vger.kernel.org
On 3/26/2020 5:00 PM, Heiner Kallweit wrote:
> If we have scenarios like
>
> mdiobus_register()
> -> loads PHY driver module(s)
> -> registers PHY driver(s)
> -> may schedule async probe
> phydev = mdiobus_get_phy()
> <phydev action involving PHY driver>
>
> or
>
> phydev = phy_device_create()
> -> loads PHY driver module
> -> registers PHY driver
> -> may schedule async probe
> <phydev action involving PHY driver>
>
> then we expect the PHY driver to be bound to the phydev when triggering
> the action. This may not be the case in case of asynchronous probing.
> Therefore ensure that PHY drivers are probed synchronously.
>
> Default still is sync probing, except async probing is explicitly
> requested. I saw some comments that the intention is to promote
> async probing for more parallelism in boot process and want to be
> prepared for the case that the default is changed to async probing.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next v2] net: phy: probe PHY drivers synchronously
2020-03-27 0:00 [PATCH net-next v2] net: phy: probe PHY drivers synchronously Heiner Kallweit
2020-03-27 0:02 ` Florian Fainelli
@ 2020-03-27 0:09 ` Andrew Lunn
2020-03-27 2:43 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-03-27 0:09 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Florian Fainelli, Russell King - ARM Linux, David Miller,
netdev@vger.kernel.org
On Fri, Mar 27, 2020 at 01:00:22AM +0100, Heiner Kallweit wrote:
> If we have scenarios like
>
> mdiobus_register()
> -> loads PHY driver module(s)
> -> registers PHY driver(s)
> -> may schedule async probe
> phydev = mdiobus_get_phy()
> <phydev action involving PHY driver>
>
> or
>
> phydev = phy_device_create()
> -> loads PHY driver module
> -> registers PHY driver
> -> may schedule async probe
> <phydev action involving PHY driver>
>
> then we expect the PHY driver to be bound to the phydev when triggering
> the action. This may not be the case in case of asynchronous probing.
> Therefore ensure that PHY drivers are probed synchronously.
>
> Default still is sync probing, except async probing is explicitly
> requested. I saw some comments that the intention is to promote
> async probing for more parallelism in boot process and want to be
> prepared for the case that the default is changed to async probing.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next v2] net: phy: probe PHY drivers synchronously
2020-03-27 0:00 [PATCH net-next v2] net: phy: probe PHY drivers synchronously Heiner Kallweit
2020-03-27 0:02 ` Florian Fainelli
2020-03-27 0:09 ` Andrew Lunn
@ 2020-03-27 2:43 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-03-27 2:43 UTC (permalink / raw)
To: hkallweit1; +Cc: andrew, f.fainelli, linux, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Fri, 27 Mar 2020 01:00:22 +0100
> If we have scenarios like
>
> mdiobus_register()
> -> loads PHY driver module(s)
> -> registers PHY driver(s)
> -> may schedule async probe
> phydev = mdiobus_get_phy()
> <phydev action involving PHY driver>
>
> or
>
> phydev = phy_device_create()
> -> loads PHY driver module
> -> registers PHY driver
> -> may schedule async probe
> <phydev action involving PHY driver>
>
> then we expect the PHY driver to be bound to the phydev when triggering
> the action. This may not be the case in case of asynchronous probing.
> Therefore ensure that PHY drivers are probed synchronously.
>
> Default still is sync probing, except async probing is explicitly
> requested. I saw some comments that the intention is to promote
> async probing for more parallelism in boot process and want to be
> prepared for the case that the default is changed to async probing.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied, thanks Heiner.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-27 2:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-27 0:00 [PATCH net-next v2] net: phy: probe PHY drivers synchronously Heiner Kallweit
2020-03-27 0:02 ` Florian Fainelli
2020-03-27 0:09 ` Andrew Lunn
2020-03-27 2:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).