From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4017DC43331 for ; Fri, 27 Mar 2020 16:23:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 180D620658 for ; Fri, 27 Mar 2020 16:23:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727769AbgC0QXu (ORCPT ); Fri, 27 Mar 2020 12:23:50 -0400 Received: from correo.us.es ([193.147.175.20]:37748 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727652AbgC0QXt (ORCPT ); Fri, 27 Mar 2020 12:23:49 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 19FFAE8E90 for ; Fri, 27 Mar 2020 17:23:48 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id F0B37DA3A1 for ; Fri, 27 Mar 2020 17:23:47 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id DA2E3DA72F; Fri, 27 Mar 2020 17:23:47 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 076DFDA736; Fri, 27 Mar 2020 17:23:46 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 27 Mar 2020 17:23:46 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id E00F742EE38E; Fri, 27 Mar 2020 17:23:45 +0100 (CET) Date: Fri, 27 Mar 2020 17:23:45 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: David Miller Cc: wenxu@ucloud.cn, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH net-next v2] netfilter: Fix incorrect tc_setup_type type for flowtable offload Message-ID: <20200327162345.jcas4dez5ximalvn@salvia> References: <1585006465-27664-1-git-send-email-wenxu@ucloud.cn> <20200326.200409.835123184765124238.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200326.200409.835123184765124238.davem@davemloft.net> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 26, 2020 at 08:04:09PM -0700, David Miller wrote: > From: wenxu@ucloud.cn > Date: Tue, 24 Mar 2020 07:34:25 +0800 > > > From: wenxu > > > > Flowtable offload setup flow_offlod_block in TC_SETP_FT. The indr block > > offload of flowtable also should setup in TC_SETUP_FT. > > But flow_indr_block_call always sets the tc_set_up_type as TC_SETUP_BLOCK. > > So function flow_indr_block_call should expose a parameters to set > > the tc_setup_type for each offload subsystem. > > > > Fixes: b5140a36da78 ("netfilter: flowtable: add indr block setup support") > > Signed-off-by: wenxu > > --- > > v2: modify the comments > > Do the netfilter folks want to take this or should I apply it directly? We'll take care of this patch, thank you.