From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBDCFC2D0ED for ; Fri, 27 Mar 2020 18:56:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5E692071B for ; Fri, 27 Mar 2020 18:56:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Re/P2YH7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727347AbgC0S4R (ORCPT ); Fri, 27 Mar 2020 14:56:17 -0400 Received: from mail-pj1-f51.google.com ([209.85.216.51]:52873 "EHLO mail-pj1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbgC0S4R (ORCPT ); Fri, 27 Mar 2020 14:56:17 -0400 Received: by mail-pj1-f51.google.com with SMTP id ng8so4245025pjb.2; Fri, 27 Mar 2020 11:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Mc4gnjwv+NorZuWShLTClne9UWocZJwmdrYE9fdLcqs=; b=Re/P2YH7XsvR4J+PRByySEn5OTMEInkf2SrhInM49wks3p/bGpkY4luWBvfcZmOa+M 08XTHEldC2fYcprxAF327MyzpxHLD96jmWjpNF0JAYvUJ/Yc2QQqI51kjJrOt4wDMkQR 9Fb/DwDiAV8nXY0DqhfUM/vfVhEKwLSX3A1MdIIW7sQzOs9/YGm+uskbewpjPiIdy4v/ lCs9B/mIKAwptV3mWlinXD7VR1AXnCHUwtBJYHGv+cBxpLXVuSL98R0mRKuXshOrawdU iA7IyKb3CwcV9VPKspEdXxxrlavSYGzCXNK2OJbfMeiBNKDSvpAEH8gY6ULN8AXyyKvJ K+cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Mc4gnjwv+NorZuWShLTClne9UWocZJwmdrYE9fdLcqs=; b=B1YtrWHf5EjHjs2mfwIjwAgvxdOe4EeMqb3RLHqxwnG7RuWZ0uKgWscLyS3tsAQMCp WdB9J7rW7IsT7Kg7jnOSXhWZ6uu7oPzHSiDRbH7NbWIibmbVl/WmywOYLLFhqK7V2+Iw nsP4AHDoQSNCjF9L+G4AvW4hZEoxCNbCn3X/8BC+8iP3pUs1fmD/RDXyxVAg79CJP1za qBkcOJa/NiXe7Fwq7bP0PnPBYlZ6yBd+md93ffXH0AJwlfChUoQIAGWR7rGeph/kH2Nq rnAz+f05YotYeqxfzj3fdxAeI2bSF9Zyedn0aLHUQcDSEt22oOrqaDhSgeSW2a/jxCsk YRDw== X-Gm-Message-State: ANhLgQ0vxsqx+hC+rrR2+3tQu52DDb1JJL1YSzivCZ5mbulTHDD9MPNy 5yOlOTateKst82iEn73gnkZ2+2n3 X-Google-Smtp-Source: ADFU+vt1wa+jcH3CbuTaPOaz1kYZpblawTT3hlHlCpr1TeHjUNg/811xk6GEw/fHDs8oWaj9zW8vgQ== X-Received: by 2002:a17:90a:fd90:: with SMTP id cx16mr898109pjb.41.1585335375600; Fri, 27 Mar 2020 11:56:15 -0700 (PDT) Received: from localhost (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id x188sm4784948pfx.198.2020.03.27.11.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2020 11:56:15 -0700 (PDT) Date: Fri, 27 Mar 2020 11:56:13 -0700 From: Richard Cochran To: Michal Kubecek Cc: David Miller , Jakub Kicinski , netdev@vger.kernel.org, Jiri Pirko , Andrew Lunn , Florian Fainelli , John Linville , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 12/12] ethtool: provide timestamping information with TIMESTAMP_GET request Message-ID: <20200327185613.GB28023@localhost> References: <5a3af8d892cafe9d9a2dc367e9ae463691261305.1585316159.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a3af8d892cafe9d9a2dc367e9ae463691261305.1585316159.git.mkubecek@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 27, 2020 at 03:08:17PM +0100, Michal Kubecek wrote: > +/* TIMESTAMP */ > + > +enum { > + ETHTOOL_A_TIMESTAMP_UNSPEC, I suggest using ETHTOOL_A_TSINFO_ throughout. After all, this API does not provide time stamps, and we want to avoid confusion. > + ETHTOOL_A_TIMESTAMP_HEADER, /* nest - _A_HEADER_* */ > + ETHTOOL_A_TIMESTAMP_TIMESTAMPING, /* bitset */ > + ETHTOOL_A_TIMESTAMP_TX_TYPES, /* bitset */ > + ETHTOOL_A_TIMESTAMP_RX_FILTERS, /* bitset */ > + ETHTOOL_A_TIMESTAMP_PHC_INDEX, /* u32 */ > + > + /* add new constants above here */ > + __ETHTOOL_A_TIMESTAMP_CNT, > + ETHTOOL_A_TIMESTAMP_MAX = (__ETHTOOL_A_TIMESTAMP_CNT - 1) > +}; Acked-by: Richard Cochran