From: Jiri Pirko <jiri@resnulli.us>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
John Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
Richard Cochran <richardcochran@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 00/12] ethtool netlink interface, part 4
Date: Sat, 28 Mar 2020 11:08:05 +0100 [thread overview]
Message-ID: <20200328100805.GO11304@nanopsycho.orion> (raw)
In-Reply-To: <cover.1585349448.git.mkubecek@suse.cz>
Sat, Mar 28, 2020 at 12:00:58AM CET, mkubecek@suse.cz wrote:
>Implementation of more netlink request types:
>
> - coalescing (ethtool -c/-C, patches 2-4)
> - pause parameters (ethtool -a/-A, patches 5-7)
> - EEE settings (--show-eee / --set-eee, patches 8-10)
> - timestamping info (-T, patches 11-12)
>
>Patch 1 is a fix for netdev reference leak similar to commit 2f599ec422ad
>("ethtool: fix reference leak in some *_SET handlers") but fixing a code
>
>Changes in v3
> - change "one-step-*" Tx type names to "onestep-*", (patch 11, suggested
> by Richard Cochran
> - use "TSINFO" rather than "TIMESTAMP" for timestamping information
> constants and adjust symbol names (patch 12, suggested by Richard
> Cochran)
>
>Changes in v2:
> - fix compiler warning in net_hwtstamp_validate() (patch 11)
> - fix follow-up lines alignment (whitespace only, patches 3 and 8)
>which is only in net-next tree at the moment.
>
>Michal Kubecek (12):
> ethtool: fix reference leak in ethnl_set_privflags()
> ethtool: provide coalescing parameters with COALESCE_GET request
> ethtool: set coalescing parameters with COALESCE_SET request
> ethtool: add COALESCE_NTF notification
> ethtool: provide pause parameters with PAUSE_GET request
> ethtool: set pause parameters with PAUSE_SET request
> ethtool: add PAUSE_NTF notification
> ethtool: provide EEE settings with EEE_GET request
> ethtool: set EEE settings with EEE_SET request
> ethtool: add EEE_NTF notification
> ethtool: add timestamping related string sets
> ethtool: provide timestamping information with TSINFO_GET request
FWIW, this looks fine to me.
set-
Acked-by: Jiri Pirko <jiri@mellanox.com>
Thanks Michal!
next prev parent reply other threads:[~2020-03-28 10:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 23:00 [PATCH net-next v3 00/12] ethtool netlink interface, part 4 Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 01/12] ethtool: fix reference leak in ethnl_set_privflags() Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 02/12] ethtool: provide coalescing parameters with COALESCE_GET request Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 03/12] ethtool: set coalescing parameters with COALESCE_SET request Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 04/12] ethtool: add COALESCE_NTF notification Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 05/12] ethtool: provide pause parameters with PAUSE_GET request Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 06/12] ethtool: set pause parameters with PAUSE_SET request Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 07/12] ethtool: add PAUSE_NTF notification Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 08/12] ethtool: provide EEE settings with EEE_GET request Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 09/12] ethtool: set EEE settings with EEE_SET request Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 10/12] ethtool: add EEE_NTF notification Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 11/12] ethtool: add timestamping related string sets Michal Kubecek
2020-03-27 23:01 ` [PATCH net-next v3 12/12] ethtool: provide timestamping information with TSINFO_GET request Michal Kubecek
2020-03-28 10:08 ` Jiri Pirko [this message]
2020-03-30 5:33 ` [PATCH net-next v3 00/12] ethtool netlink interface, part 4 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328100805.GO11304@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox