From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4513CC43331 for ; Mon, 30 Mar 2020 05:21:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2017920733 for ; Mon, 30 Mar 2020 05:21:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728553AbgC3FVL (ORCPT ); Mon, 30 Mar 2020 01:21:11 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33342 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728349AbgC3FVL (ORCPT ); Mon, 30 Mar 2020 01:21:11 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 77BDF15C70528; Sun, 29 Mar 2020 22:21:10 -0700 (PDT) Date: Sun, 29 Mar 2020 22:21:09 -0700 (PDT) Message-Id: <20200329.222109.1183931707971302785.davem@davemloft.net> To: w.dauchy@criteo.com Cc: netdev@vger.kernel.org, nicolas.dichtel@6wind.com Subject: Re: [PATCH v3 net] net, ip_tunnel: fix interface lookup with no key From: David Miller In-Reply-To: <20200327185639.71238-1-w.dauchy@criteo.com> References: <20200327145444.61875-1-w.dauchy@criteo.com> <20200327185639.71238-1-w.dauchy@criteo.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 29 Mar 2020 22:21:10 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: William Dauchy Date: Fri, 27 Mar 2020 19:56:39 +0100 > when creating a new ipip interface with no local/remote configuration, > the lookup is done with TUNNEL_NO_KEY flag, making it impossible to > match the new interface (only possible match being fallback or metada > case interface); e.g: `ip link add tunl1 type ipip dev eth0` > > To fix this case, adding a flag check before the key comparison so we > permit to match an interface with no local/remote config; it also avoids > breaking possible userland tools relying on TUNNEL_NO_KEY flag and > uninitialised key. > > context being on my side, I'm creating an extra ipip interface attached > to the physical one, and moving it to a dedicated namespace. > > Fixes: c54419321455 ("GRE: Refactor GRE tunneling code.") > Signed-off-by: William Dauchy Applied and queued up for -stable, thanks.