From: Florian Westphal <fw@strlen.de>
To: Sergey Marinkevich <sergey.marinkevich@eltex-co.ru>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_exthdr: fix endianness of tcp option cast
Date: Sun, 29 Mar 2020 15:44:36 +0200 [thread overview]
Message-ID: <20200329134436.GA23604@breakpoint.cc> (raw)
In-Reply-To: <20200329121914.GA7748@GRayJob>
Sergey Marinkevich <sergey.marinkevich@eltex-co.ru> wrote:
> I got a problem on MIPS with Big-Endian is turned on: every time when
> NF trying to change TCP MSS it returns because of new.v16 was greater
> than old.v16. But real MSS was 1460 and my rule was like this:
>
> add rule table chain tcp option maxseg size set 1400
>
> And 1400 is lesser that 1460, not greater.
>
> Later I founded that main causer is cast from u32 to __be16.
LGTM.
Acked-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2020-03-29 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 12:19 [PATCH nf] netfilter: nft_exthdr: fix endianness of tcp option cast Sergey Marinkevich
2020-03-29 13:44 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200329134436.GA23604@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sergey.marinkevich@eltex-co.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).