Re: [PATCH v2] net/bpfilter: fix dprintf usage for /dev/kmsg

[Bruno Meneguele <bmeneg@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On Mon, Mar 30, 2020 at 03:48:12PM +0300, Martin Zaharinov wrote:
> Hi Bruno
> i see after release kernel 5.6.0 with your latest patch have strange
> messages please check:
> 
> [   31.025483] bpfilter: Loaded bpfilter_umh pid 2689
> [   31.025533] Started bpfilter
> [   31.042586] testing the buffer
> [   31.050822] testing the buffer
> [   31.059304] testing the buffer
> [   31.067747] testing the buffer
> [   31.148789] testing the buffer
> [   31.156130] testing the buffer
> [   31.164012] testing the buffer
> [   31.170685] testing the buffer
> [   31.176886] testing the buffer
> 
> when drop bpfilter module stop enter new messages in kmsg.
> 

Hi Martin,

these aren't really "strange messages", but the correct ones. They
started to appear now because before my patch the log wasn't working at
all. I'm not really aware what is the logic behind the bpfilter_umh
module, but AFAIK each iptable rule sent from kernel side to UMH
userspace code will generate one "testing the buffer" message.

I think we can silence it by limiting it to print only once, but I would
need to check with Alexei Starovoitov <ast@kernel.org> if it would be
fine (CC'ing here).

Thanks for the heads up :).

-- 
bmeneg 
PGP Key: http://bmeneg.com/pubkey.txt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]