netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* ingress rate limiting on mv88e6xxx
@ 2020-03-30 13:22 Rasmus Villemoes
  2020-03-30 13:26 ` Andrew Lunn
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Rasmus Villemoes @ 2020-03-30 13:22 UTC (permalink / raw)
  To: Network Development; +Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli

I'm trying to figure out what the proper way is to expose the ingress
rate limiting knobs of the mv88e6250 (and related) to userspace. The
simpest seems to be a set of sysfs files for each port, but I'm assuming
that's a no-go (?)

So what is the right way, and has anyone looked at hooking this up?

Thanks,
Rasmus

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ingress rate limiting on mv88e6xxx
  2020-03-30 13:22 ingress rate limiting on mv88e6xxx Rasmus Villemoes
@ 2020-03-30 13:26 ` Andrew Lunn
  2020-03-30 13:26 ` Vladimir Oltean
  2020-03-30 23:01 ` Jakub Kicinski
  2 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2020-03-30 13:26 UTC (permalink / raw)
  To: Rasmus Villemoes; +Cc: Network Development, Vivien Didelot, Florian Fainelli

On Mon, Mar 30, 2020 at 03:22:44PM +0200, Rasmus Villemoes wrote:
> I'm trying to figure out what the proper way is to expose the ingress
> rate limiting knobs of the mv88e6250 (and related) to userspace. The
> simpest seems to be a set of sysfs files for each port, but I'm assuming
> that's a no-go (?)
> 
> So what is the right way, and has anyone looked at hooking this up?

Hi Rasmus

You need to map TC to the switch QoS functions.

    Andrew

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ingress rate limiting on mv88e6xxx
  2020-03-30 13:22 ingress rate limiting on mv88e6xxx Rasmus Villemoes
  2020-03-30 13:26 ` Andrew Lunn
@ 2020-03-30 13:26 ` Vladimir Oltean
  2020-03-30 23:35   ` Florian Fainelli
  2020-03-30 23:01 ` Jakub Kicinski
  2 siblings, 1 reply; 5+ messages in thread
From: Vladimir Oltean @ 2020-03-30 13:26 UTC (permalink / raw)
  To: Rasmus Villemoes
  Cc: Network Development, Andrew Lunn, Vivien Didelot,
	Florian Fainelli

Hi Rasmus,

On Mon, 30 Mar 2020 at 16:23, Rasmus Villemoes
<rasmus.villemoes@prevas.dk> wrote:
>
> I'm trying to figure out what the proper way is to expose the ingress
> rate limiting knobs of the mv88e6250 (and related) to userspace. The
> simpest seems to be a set of sysfs files for each port, but I'm assuming
> that's a no-go (?)
>
> So what is the right way, and has anyone looked at hooking this up?
>
> Thanks,
> Rasmus

Does this give you any ideas?
https://patchwork.ozlabs.org/cover/1263417/

Regards,
-Vladimir

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ingress rate limiting on mv88e6xxx
  2020-03-30 13:22 ingress rate limiting on mv88e6xxx Rasmus Villemoes
  2020-03-30 13:26 ` Andrew Lunn
  2020-03-30 13:26 ` Vladimir Oltean
@ 2020-03-30 23:01 ` Jakub Kicinski
  2 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2020-03-30 23:01 UTC (permalink / raw)
  To: Rasmus Villemoes, Andrew Lunn
  Cc: Network Development, Vivien Didelot, Florian Fainelli

On Mon, 30 Mar 2020 15:22:44 +0200 Rasmus Villemoes wrote:
> I'm trying to figure out what the proper way is to expose the ingress
> rate limiting knobs of the mv88e6250 (and related) to userspace. The
> simpest seems to be a set of sysfs files for each port, but I'm assuming
> that's a no-go (?)

Out of curiosity - is this policing (i.e. dropping)?  Are there any
switches out there which would generate pause frames if port / priority
is above a certain threshold?


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ingress rate limiting on mv88e6xxx
  2020-03-30 13:26 ` Vladimir Oltean
@ 2020-03-30 23:35   ` Florian Fainelli
  0 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2020-03-30 23:35 UTC (permalink / raw)
  To: Vladimir Oltean, Rasmus Villemoes
  Cc: Network Development, Andrew Lunn, Vivien Didelot



On 3/30/2020 6:26 AM, Vladimir Oltean wrote:
> Hi Rasmus,
> 
> On Mon, 30 Mar 2020 at 16:23, Rasmus Villemoes
> <rasmus.villemoes@prevas.dk> wrote:
>>
>> I'm trying to figure out what the proper way is to expose the ingress
>> rate limiting knobs of the mv88e6250 (and related) to userspace. The
>> simpest seems to be a set of sysfs files for each port, but I'm assuming
>> that's a no-go (?)
>>
>> So what is the right way, and has anyone looked at hooking this up?
>>
>> Thanks,
>> Rasmus
> 
> Does this give you any ideas?
> https://patchwork.ozlabs.org/cover/1263417/

This looks like the way to do it to me.
-- 
Florian

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-03-30 23:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-30 13:22 ingress rate limiting on mv88e6xxx Rasmus Villemoes
2020-03-30 13:26 ` Andrew Lunn
2020-03-30 13:26 ` Vladimir Oltean
2020-03-30 23:35   ` Florian Fainelli
2020-03-30 23:01 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).