From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: David Miller <davem@davemloft.net>,
nic_swsd@realtek.com, cwhuang@android-x86.org,
netdev@vger.kernel.org
Subject: Re: issue with 85a19b0e31e2 on 4.19 -> revert
Date: Mon, 30 Mar 2020 17:07:10 +0200 [thread overview]
Message-ID: <20200330150710.GA614751@kroah.com> (raw)
In-Reply-To: <c8963e4a-2cda-e9f0-eb4d-f6919c58391e@gmail.com>
On Mon, Mar 30, 2020 at 04:39:08PM +0200, Heiner Kallweit wrote:
> On 30.03.2020 16:30, Greg Kroah-Hartman wrote:
> > On Sat, Mar 28, 2020 at 10:52:19AM +0100, Heiner Kallweit wrote:
> >> On 28.03.2020 00:24, David Miller wrote:
> >>> From: Heiner Kallweit <hkallweit1@gmail.com>
> >>> Date: Sat, 28 Mar 2020 00:10:57 +0100
> >>>
> >>>> Somehow that change made it to -stable. See e.g. commit
> >>>> 85a19b0e31e256e77fd4124804b9cec10619de5e for 4.19.
> >>>
> >>> This is a serious issue in that it seems that the people maintaining
> >>> the older stable release integrate arbitrary patches even if they
> >>> haven't been sent to v5.4 and v5.5
> >>>
> >>> And I don't handle -stable backport submissions that far back anyways.
> >>>
> >>> Therefore, I'm not going to participate in that ongoing problem, so
> >>> feel free to contact the folks who integrated those changes into
> >>> -stable and ask them to revert.
> >>>
> >>> Thanks.
> >>>
> >> Greg,
> >>
> >> commit 85a19b0e31e2 ("r8169: check that Realtek PHY driver module is loaded")
> >> made it accidentally to 4.19 and causes an issue with Android/x86.
> >> Could you please revert it?
> >
> > Now reverted. Should I also drop this from 5.4.y and 5.5.y?
> >
> Thanks! On 5.4 and 5.5 it's not needed to revert. The following fix from 5.6
> should make it to 5.4 and 5.5 soon.
>
> 2e8c339b4946 ("r8169: fix PHY driver check on platforms w/o module softdeps")
I don't see it in David's queue, so I'll go take it now for those trees.
thanks,
greg k-h
prev parent reply other threads:[~2020-03-30 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 16:33 [PATCH net] r8169: fix PHY driver check on platforms w/o module softdeps Heiner Kallweit
2020-03-27 22:57 ` David Miller
2020-03-27 23:10 ` Heiner Kallweit
2020-03-27 23:24 ` David Miller
2020-03-28 9:52 ` issue with 85a19b0e31e2 on 4.19 -> revert Heiner Kallweit
2020-03-30 14:30 ` Greg Kroah-Hartman
2020-03-30 14:39 ` Heiner Kallweit
2020-03-30 15:07 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330150710.GA614751@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cwhuang@android-x86.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).