From: Andrew Lunn <andrew@lunn.ch>
To: Daniel Mack <daniel@zonque.org>
Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: don't force settings on CPU port
Date: Mon, 30 Mar 2020 20:45:17 +0200 [thread overview]
Message-ID: <20200330184517.GH23477@lunn.ch> (raw)
In-Reply-To: <82d8e785-ec00-d815-3b11-b694aa9f4d50@zonque.org>
> Even when the MAC is *forced* to 1G, which is what the code currently
> does? Sorry for the dumb question, but wich code path would undo these
> settings? Where would you start debugging this?
You could add #define DEBUG to the top of driver/net/phy/phylink.c.
You should then see what phylink is up to, including it trying to
configure the MAC. You can add additional printk to
mv88e6xxx_mac_link_up(), mv88e6xxx_mac_link_down(),
mv88e6xxx_mac_config(), etc.
Andrew
next prev parent reply other threads:[~2020-03-30 18:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 19:51 [PATCH] net: dsa: mv88e6xxx: don't force settings on CPU port Daniel Mack
2020-03-27 20:01 ` Andrew Lunn
2020-03-27 20:48 ` Daniel Mack
2020-03-27 21:18 ` Andrew Lunn
2020-03-27 21:26 ` Daniel Mack
2020-03-27 23:52 ` Andrew Lunn
2020-03-30 9:29 ` Daniel Mack
2020-03-30 13:40 ` Andrew Lunn
2020-03-30 18:04 ` Daniel Mack
2020-03-30 18:23 ` Andrew Lunn
2020-03-30 18:37 ` Daniel Mack
2020-03-30 18:45 ` Andrew Lunn [this message]
2020-06-22 18:43 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330184517.GH23477@lunn.ch \
--to=andrew@lunn.ch \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).