From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB290C43331 for ; Tue, 31 Mar 2020 14:03:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C2E420786 for ; Tue, 31 Mar 2020 14:03:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h97VAV76" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731014AbgCaODd (ORCPT ); Tue, 31 Mar 2020 10:03:33 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:33852 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730760AbgCaODc (ORCPT ); Tue, 31 Mar 2020 10:03:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585663411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q1HhUZIT2eXWaur2lhwyirTrp2FNrCuPmxOJW0kwlcg=; b=h97VAV76J4Ycxw8/+INJEEDRbcJ/k6qDhOxu/x0Rp+QThfbSW3YpQMwBEgiE5Mi4+nIwpe GKrWAbrN+knP6a8nhRtsjxZto5Zbln8uQybLPShGIjhyMClI5USZauVNoVraMtPZABC9Pl sUY0lcPcO8kQ14cP43DTuKPLpJbVD8c= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-EI0a5oCZOSqTbJxxP7cZRQ-1; Tue, 31 Mar 2020 10:03:29 -0400 X-MC-Unique: EI0a5oCZOSqTbJxxP7cZRQ-1 Received: by mail-wr1-f70.google.com with SMTP id k11so39435wrm.19 for ; Tue, 31 Mar 2020 07:03:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=q1HhUZIT2eXWaur2lhwyirTrp2FNrCuPmxOJW0kwlcg=; b=YLRlEbW0glA7lHhIGgxuWGs2iCijRlYCCoI5sZbiR1MDSrUv0GVJuxl2u/ZNN+nEwf HT2DUXMPCmoIiNbj37ChcuLeA9RmlrIYiFbHRmIXtUwIzmdyyxfXKbKuFmQorVnXkXIq tBLqbhB1wUBDmbtAcCFILaG2/d+VK9H19cEdyKxIwD72rYrK/Yt4TpGx24NkyFN55z18 8M7LbQN3W0qwhaGtVcRw6rf+7W2LR7jAmTyr2RW8Zxc0VfMzk9Sfg69BrMYDhu4GJwsS nYb/Mg0iclkBGcmthz4g6TeVJnO/wEHa9sSpahZfqOJX8PHVJMA/tKPRWh+lWgW/254H RDvA== X-Gm-Message-State: ANhLgQ0Glz1xIqFCvO6cweOa0eV1O5Hjo4mZKREAxTpKAI6Qq5loMXsP mjbJplxt+6HEbCo5wwXsIU8gNCmPhnvmXB5vTbya8ZuKkJ/Ysjfpk9V2XYfb3x1b55BkZEIz8wW +YPhUn1F5iDmb7DNN X-Received: by 2002:a1c:2203:: with SMTP id i3mr3685873wmi.25.1585663408664; Tue, 31 Mar 2020 07:03:28 -0700 (PDT) X-Google-Smtp-Source: ADFU+vulRkkpxXMxZEng5aERNo4jJ/g5cD0Vhw5jYc5ZRlaSa1jWBjmSh3+3XcGa4A4n7qFMJ8cR0g== X-Received: by 2002:a1c:2203:: with SMTP id i3mr3685803wmi.25.1585663407800; Tue, 31 Mar 2020 07:03:27 -0700 (PDT) Received: from redhat.com (bzq-79-176-51-222.red.bezeqint.net. [79.176.51.222]) by smtp.gmail.com with ESMTPSA id r17sm26682436wrx.46.2020.03.31.07.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 07:03:20 -0700 (PDT) Date: Tue, 31 Mar 2020 10:03:12 -0400 From: "Michael S. Tsirkin" To: "Gustavo A. R. Silva" Cc: Jason Wang , Tiwei Bie , Eugenio =?iso-8859-1?Q?P=E9rez?= , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vhost: vdpa: remove unnecessary null check Message-ID: <20200331100122-mutt-send-email-mst@kernel.org> References: <20200330235040.GA9997@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330235040.GA9997@embeddedor> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 30, 2020 at 06:50:40PM -0500, Gustavo A. R. Silva wrote: > container_of is never null, so this null check is > unnecessary. > > Addresses-Coverity-ID: 1492006 ("Logically dead code") > Fixes: 20453a45fb06 ("vhost: introduce vDPA-based backend") > Signed-off-by: Gustavo A. R. Silva Yes weird. Was the point to test i_cdev? Tiwei? > --- > drivers/vhost/vdpa.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 421f02a8530a..3d2cb811757a 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -678,8 +678,6 @@ static int vhost_vdpa_open(struct inode *inode, struct file *filep) > int nvqs, i, r, opened; > > v = container_of(inode->i_cdev, struct vhost_vdpa, cdev); > - if (!v) > - return -ENODEV; > > opened = atomic_cmpxchg(&v->opened, 0, 1); > if (opened) > -- > 2.26.0