From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F324C2D0F0 for ; Wed, 1 Apr 2020 18:14:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D6052063A for ; Wed, 1 Apr 2020 18:14:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732579AbgDASO3 (ORCPT ); Wed, 1 Apr 2020 14:14:29 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37464 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727723AbgDASO3 (ORCPT ); Wed, 1 Apr 2020 14:14:29 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7991C11D69C3E; Wed, 1 Apr 2020 11:14:28 -0700 (PDT) Date: Wed, 01 Apr 2020 11:14:27 -0700 (PDT) Message-Id: <20200401.111427.789296252666544265.davem@davemloft.net> To: jarod@redhat.com Cc: linux-kernel@vger.kernel.org, moshele@mellanox.com, stephen@networkplumber.org, mleitner@redhat.com, netdev@vger.kernel.org Subject: Re: [PATCH net v2] ipv6: don't auto-add link-local address to lag ports From: David Miller In-Reply-To: <20200330152219.58296-1-jarod@redhat.com> References: <20200330152219.58296-1-jarod@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 01 Apr 2020 11:14:28 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jarod Wilson Date: Mon, 30 Mar 2020 11:22:19 -0400 > Bonding slave and team port devices should not have link-local addresses > automatically added to them, as it can interfere with openvswitch being > able to properly add tc ingress. > > Basic reproducer, courtesy of Marcelo: ... > (above trimmed to relevant entries, obviously) > > $ sysctl net.ipv6.conf.ens2f0np0.addr_gen_mode=0 > net.ipv6.conf.ens2f0np0.addr_gen_mode = 0 > $ sysctl net.ipv6.conf.ens2f1np2.addr_gen_mode=0 > net.ipv6.conf.ens2f1np2.addr_gen_mode = 0 > > $ ip a l ens2f0np0 > 2: ens2f0np0: mtu 1500 qdisc > mq master bond0 state UP group default qlen 1000 > link/ether 00:0f:53:2f:ea:40 brd ff:ff:ff:ff:ff:ff > inet6 fe80::20f:53ff:fe2f:ea40/64 scope link tentative > valid_lft forever preferred_lft forever > $ ip a l ens2f1np2 > 5: ens2f1np2: mtu 1500 qdisc > mq master bond0 state DOWN group default qlen 1000 > link/ether 00:0f:53:2f:ea:40 brd ff:ff:ff:ff:ff:ff > inet6 fe80::20f:53ff:fe2f:ea40/64 scope link tentative > valid_lft forever preferred_lft forever > > Looks like addrconf_sysctl_addr_gen_mode() bypasses the original "is > this a slave interface?" check added by commit c2edacf80e15, and > results in an address getting added, while w/the proposed patch added, > no address gets added. This simply adds the same gating check to another > code path, and thus should prevent the same devices from erroneously > obtaining an ipv6 link-local address. > > Fixes: d35a00b8e33d ("net/ipv6: allow sysctl to change link-local address generation mode") > Reported-by: Moshe Levi > CC: Stephen Hemminger > CC: Marcelo Ricardo Leitner > CC: netdev@vger.kernel.org > Signed-off-by: Jarod Wilson Applied and queued up for -stable, thanks.