From: Andrew Lunn <andrew@lunn.ch>
To: Codrin.Ciubotariu@microchip.com
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net
Subject: Re: [PATCH] net: mdio: of: Do not treat fixed-link as PHY
Date: Wed, 1 Apr 2020 15:06:45 +0200 [thread overview]
Message-ID: <20200401130645.GB71179@lunn.ch> (raw)
In-Reply-To: <12cdbe77-b932-9194-5d5e-5058622cef6c@microchip.com>
> Hi Andrew
>
> >
> > There are some still using this deprecated feature. But macb is the
> > only one doing this odd looping over child nodes. It is this looping
> > which is breaking things, not the use of the deprecated feature
> > itself.
>
> Yes, its due to the fact that the MDIO node is missing. Should we have
> in mind to add an MDIO node under the macb node, where we could add the
> PHY nodes?
Yes, you can make the driver complient any time you want. But as you
said, you need to keep with backwards compatibility. But net-next is
closed now, for the merge window. So you probably want to wait two
weeks before posting code.
Andrew
prev parent reply other threads:[~2020-04-01 13:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 16:01 [PATCH] net: mdio: of: Do not treat fixed-link as PHY Codrin Ciubotariu
2020-03-30 16:17 ` Andrew Lunn
2020-03-30 16:21 ` Russell King - ARM Linux admin
2020-03-30 16:24 ` Andrew Lunn
2020-03-30 16:30 ` Andrew Lunn
2020-03-30 17:22 ` Florian Fainelli
2020-03-31 8:54 ` Codrin.Ciubotariu
2020-03-31 12:59 ` Andrew Lunn
2020-04-01 7:50 ` Codrin.Ciubotariu
2020-04-01 13:06 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401130645.GB71179@lunn.ch \
--to=andrew@lunn.ch \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).