From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BADDC2D0E8 for ; Fri, 3 Apr 2020 11:44:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72CA72078C for ; Fri, 3 Apr 2020 11:44:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X4r92T3r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390795AbgDCLoO (ORCPT ); Fri, 3 Apr 2020 07:44:14 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41524 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728012AbgDCLoN (ORCPT ); Fri, 3 Apr 2020 07:44:13 -0400 Received: by mail-pg1-f195.google.com with SMTP id b1so3386632pgm.8; Fri, 03 Apr 2020 04:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cFqKhUUJU9qMbUtcScPZKyOAp/7CIJ/yVuLhxtE3jjU=; b=X4r92T3rqVMkBBYRjDIQ+STjElQABrd3jNT41KchZpSiPnyhN47ULzxX1tfFbZFKh7 kQnG3TK50rLvNVpydlAt6MaqX48aYFUhY7VXOwb9rsr5gRPHK9W1angYdr7tyhRX9/W5 cV2cTKWmBUmR6hJBNa3WE0ITv0dg/GQaXW7gGxROD+nDO3Ej0QrY/seuGbDEL17sSseT PjNwun3JiLuR1vpWQwofZHXmlP1qh+JzuB005yL1SmCx+gkL+3fSQdxu0UApJBwRp/+Y VdNwSrYnxVFcvfhjcgXYOCl/scQ/EJ/irKlfbSUOUotyBWR7OUccQDk9SGiUCSq50Arw qn4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cFqKhUUJU9qMbUtcScPZKyOAp/7CIJ/yVuLhxtE3jjU=; b=tqG4b9sI9eeDIlE+OfaLulfORgAa0yLOwa553aQzlXLN7TKdM6R7AY4Bk3wdsWrR8K 2kp6X5dfU9cwLL5LGuEJcDvK/3cTWkM++ooSXzOvEkruq6mxz4AJxlZYharBNJ0zLbXb AJiJrkeHIiKUeGothzX5YjwxCA8v0VxRZNJAaO3plTKMO/W1eKnSWiGynxMbLIiDqzdy fKekFsYR9IfcurzRHxWH0Gb9YWTigulL4MKNZ548wEplNVE7PFhPLNKD7SGnkyJGo0D+ UvOIGjEqNKxw38YcSliW9lSepcl2jSIdi9qQDLg+uRl+2IivQAJPVoS08U4sNPfW1+qm 6Uow== X-Gm-Message-State: AGi0PuZ4EhjD5aKUQ101fW54BxGXxqaKyHo5eqGQCA70w5qpzZ5LnHv6 EcbpmHcBoc4kPVSIqQHmFs8= X-Google-Smtp-Source: APiQypKm3j6gxjUjyAFb8U7RWHgyQRizTjjY/NDPwQVqXMWxIgIcK5OrBRvbiAdLI4HUkaUg929M5A== X-Received: by 2002:a65:6855:: with SMTP id q21mr7921930pgt.188.1585914252186; Fri, 03 Apr 2020 04:44:12 -0700 (PDT) Received: from localhost ([43.224.245.180]) by smtp.gmail.com with ESMTPSA id a8sm5054817pgg.79.2020.04.03.04.44.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Apr 2020 04:44:11 -0700 (PDT) Date: Fri, 3 Apr 2020 19:41:58 +0800 From: Geliang Tang To: Matthieu Baerts Cc: Mat Martineau , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mptcp: move pr_fmt defining to protocol.h Message-ID: <20200403114157.GA10201@OptiPlex> References: <34c83a5fe561739c7b85a3c4959eb44c3155d075.1585899578.git.geliangtang@gmail.com> <9674b6ce-3888-557e-8f32-230671363903@tessares.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9674b6ce-3888-557e-8f32-230671363903@tessares.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 03, 2020 at 12:29:27PM +0200, Matthieu Baerts wrote: > Hi Geliang, > > On 03/04/2020 09:57, Geliang Tang wrote: > > Some of the mptcp logs didn't print out the format string "MPTCP": > > > > [ 129.185774] DSS > > [ 129.185774] data_fin=0 dsn64=1 use_map=1 ack64=1 use_ack=1 > > [ 129.185774] data_ack=5481534886531492085 > > [ 129.185775] data_seq=15725204003114694615 subflow_seq=1425409 data_len=5216 > > [ 129.185776] subflow=0000000093526a92 fully established=1 seq=0:0 remaining=28 > > [ 129.185776] MPTCP: msk=00000000d5a704a6 ssk=00000000b5aabc31 data_avail=0 skb=0000000088f05424 > > [ 129.185777] MPTCP: seq=15725204003114694615 is64=1 ssn=1425409 data_len=5216 data_fin=0 > > [ 129.185777] MPTCP: msk=00000000d5a704a6 ssk=00000000b5aabc31 status=0 > > [ 129.185778] MPTCP: msk ack_seq=da3b25b9a233c2c7 subflow ack_seq=da3b25b9a233c2c7 > > [ 129.185778] MPTCP: msk=00000000d5a704a6 ssk=00000000b5aabc31 data_avail=1 skb=000000000caed2cc > > [ 129.185779] subflow=0000000093526a92 fully established=1 seq=0:0 remaining=28 > > > > So this patch moves the pr_fmt defining from protocol.c to protocol.h, which > > is included by all the C files. Then we can get the same format string > > "MPTCP" in all mptcp logs like this: > > > > [ 141.854787] MPTCP: DSS > > [ 141.854788] MPTCP: data_fin=0 dsn64=1 use_map=1 ack64=1 use_ack=1 > > [ 141.854788] MPTCP: data_ack=18028325517710311871 > > [ 141.854788] MPTCP: data_seq=6163976859259356786 subflow_seq=3309569 data_len=8192 > > [ 141.854789] MPTCP: msk=000000005847a66a ssk=0000000022469903 data_avail=0 skb=00000000dd95efc3 > > [ 141.854789] MPTCP: seq=6163976859259356786 is64=1 ssn=3309569 data_len=8192 data_fin=0 > > [ 141.854790] MPTCP: msk=000000005847a66a ssk=0000000022469903 status=0 > > [ 141.854790] MPTCP: msk ack_seq=558ad84b9be1d162 subflow ack_seq=558ad84b9be1d162 > > [ 141.854791] MPTCP: msk=000000005847a66a ssk=0000000022469903 data_avail=1 skb=000000000b8926f6 > > [ 141.854791] MPTCP: subflow=00000000e4e4579c fully established=1 seq=0:0 remaining=28 > > [ 141.854792] MPTCP: subflow=00000000e4e4579c fully established=1 seq=0:dcdf2f3b remaining=28 > > Good idea to uniform that. > I think it can be useful for MPTCP devs to add a different prefix in each > MPTCP .c files but this small improvement can be done later. > > LGTM, thanks Geliang! > > Reviewed-by: Matthieu Baerts Hi Matthieu, Thanks for your reply. I have already resend this patch to you, a better version, v2, added pr_fmt in each .c files. -Geliang