From: Taehee Yoo <ap420073@gmail.com>
To: davem@davemloft.net, kuba@kernel.org, gregkh@linuxfoundation.org,
rafael@kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com,
andy@greyhouse.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ap420073@gmail.com, mitch.a.williams@intel.com
Subject: [PATCH net v2 2/3] net: core: add netdev_class_has_file_ns() helper function
Date: Sat, 4 Apr 2020 14:19:09 +0000 [thread overview]
Message-ID: <20200404141909.26399-1-ap420073@gmail.com> (raw)
This helper function is to check whether the class file "/sys/class/net/*"
is existing or not.
In the next patch, this helper function will be used.
Reported-by: syzbot+830c6dbfc71edc4f0b8f@syzkaller.appspotmail.com
Fixes: b76cdba9cdb2 ("[PATCH] bonding: add sysfs functionality to bonding (large)")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
v1 -> v2:
- use class_has_file_ns(), which is introduced by the first patch.
include/linux/netdevice.h | 2 +-
net/core/net-sysfs.c | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 130a668049ab..a04c487c0975 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -4555,7 +4555,7 @@ int netdev_class_create_file_ns(const struct class_attribute *class_attr,
const void *ns);
void netdev_class_remove_file_ns(const struct class_attribute *class_attr,
const void *ns);
-
+bool netdev_class_has_file_ns(const char *name, const void *ns);
static inline int netdev_class_create_file(const struct class_attribute *class_attr)
{
return netdev_class_create_file_ns(class_attr, NULL);
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index cf0215734ceb..8a20d658eff0 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1914,6 +1914,12 @@ void netdev_class_remove_file_ns(const struct class_attribute *class_attr,
}
EXPORT_SYMBOL(netdev_class_remove_file_ns);
+bool netdev_class_has_file_ns(const char *name, const void *ns)
+{
+ return class_has_file_ns(&net_class, name, ns);
+}
+EXPORT_SYMBOL(netdev_class_has_file_ns);
+
int __init netdev_kobject_init(void)
{
kobj_ns_type_register(&net_ns_type_operations);
--
2.17.1
next reply other threads:[~2020-04-04 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 14:19 Taehee Yoo [this message]
2020-04-04 15:51 ` [PATCH net v2 2/3] net: core: add netdev_class_has_file_ns() helper function Greg KH
2020-04-04 17:18 ` Taehee Yoo
2020-04-05 7:32 ` Greg KH
2020-04-05 9:17 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200404141909.26399-1-ap420073@gmail.com \
--to=ap420073@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).