netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bastien Roucariès" <roucaries.bastien@gmail.com>
To: netdev@vger.kernel.org
Cc: "Bastien Roucariès" <rouca@debian.org>
Subject: [PATCH iproute2 6/6] State of bridge STP port are now case insensitive
Date: Sun,  5 Apr 2020 15:48:58 +0200	[thread overview]
Message-ID: <20200405134859.57232-7-rouca@debian.org> (raw)
In-Reply-To: <20200405134859.57232-1-rouca@debian.org>

Improve use experience

Signed-off-by: Bastien Roucariès <rouca@debian.org>
---
 bridge/link.c     | 2 +-
 man/man8/bridge.8 | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/bridge/link.c b/bridge/link.c
index 074edf00..3bc7af20 100644
--- a/bridge/link.c
+++ b/bridge/link.c
@@ -378,7 +378,7 @@ static int brlink_modify(int argc, char **argv)
 			state = strtol(*argv, &endptr, 10);
 			if (!(**argv != '\0' && *endptr == '\0')) {
 				for (state = 0; state < nstates; state++)
-					if (strcmp(port_states[state], *argv) == 0)
+					if (strcasecmp(port_states[state], *argv) == 0)
 						break;
 				if (state == nstates) {
 					fprintf(stderr,
diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index 96ea4827..b7b85d1e 100644
--- a/man/man8/bridge.8
+++ b/man/man8/bridge.8
@@ -293,16 +293,16 @@ droot port selectio algorithms.
 
 .TP
 .BI state " STATE "
-the operation state of the port. Except state 0 (disabled),
+the operation state of the port. Except state 0 (disable STP),
 this is primarily used by user space STP/RSTP
-implementation. One may enter a lowercased port state name, or one of the
+implementation. One may enter port state name (case insensitive), or one of the
 numbers below. Negative inputs are ignored, and unrecognized names return an
 error.
 
 .B 0
-- port is in
+- port is in STP
 .B DISABLED
-state. Make this port completely inactive. This is also called
+state. Make this port completely inactive for STP. This is also called
 BPDU filter and could be used to disable STP on an untrusted port, like
 a leaf virtual devices.
 .sp
-- 
2.25.1


  parent reply	other threads:[~2020-04-05 13:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05 13:48 Improve documentation of bridge Bastien Roucariès
2020-04-05 13:48 ` [PATCH iproute2 1/6] Better documentation of mcast_to_unicast option Bastien Roucariès
2020-04-05 13:48 ` [PATCH iproute2 2/6] Improve hairpin mode description Bastien Roucariès
2020-04-05 13:48 ` [PATCH iproute2 3/6] Document BPDU filter option Bastien Roucariès
2020-04-05 13:48 ` [PATCH iproute2 4/6] Better documentation of BDPU guard Bastien Roucariès
2020-04-05 13:48 ` [PATCH iproute2 5/6] Document root_block option Bastien Roucariès
2020-04-06  9:54   ` Sergei Shtylyov
2020-04-05 13:48 ` Bastien Roucariès [this message]
2020-04-12 23:50 ` [V2][PATH 0/6] iproute improve documentation of bridge roucaries.bastien
2020-04-12 23:50   ` [PATCH 1/6] Better documentation of mcast_to_unicast option roucaries.bastien
2020-04-20 16:43     ` Stephen Hemminger
2020-04-12 23:50   ` [PATCH 2/6] Improve hairpin mode description roucaries.bastien
2020-04-12 23:50   ` [PATCH 3/6] Document BPDU filter option roucaries.bastien
2020-04-12 23:50   ` [PATCH 4/6] Better documentation of BDPU guard roucaries.bastien
2020-04-13  9:28     ` Sergei Shtylyov
2020-04-12 23:50   ` [PATCH 5/6] Document root_block option roucaries.bastien
2020-04-12 23:50   ` [PATCH 6/6] State of bridge STP port are now case insensitive roucaries.bastien
2020-04-20 16:51   ` [V2][PATH 0/6] iproute improve documentation of bridge Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200405134859.57232-7-rouca@debian.org \
    --to=roucaries.bastien@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rouca@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).