netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Voon Weifeng <weifeng.voon@intel.com>
To: "David S . Miller" <davem@davemloft.net>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jose Abreu <joabreu@synopsys.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Ong Boon Leong <boon.leong.ong@intel.com>,
	Voon Weifeng <weifeng.voon@intel.com>
Subject: [RFC,net-next,v2, 0/1] Enable SERDES power up/down
Date: Thu,  9 Apr 2020 23:48:22 +0800	[thread overview]
Message-ID: <20200409154823.26480-1-weifeng.voon@intel.com> (raw)

Changes from v1:
1.Only the configuration of the SERDES logic is kept, other SW acrh has
  changed.
2.Removed the proposed new files intel_serdes.c and intel_serdes.h and
  moved the SERDES configuration logic to dwmac-intel.c and dwmac_intel.h.
3.Added 2 BSP callbacks ->serdes_powerup() and ->serdes_powerup().
4.The suggested 2 new BSP callbacks is called in stmmac_dvr_probe() and
  stmmac_dvr_remove().

This platform specific SERDES configuration not able separate 100% cleanly
from the main dwmac logic because mdio communication is needed for
configuring the SERDES power-up sequence. As for SERDES power-down
sequence, it must be configured after all dma stop and before unregister
the mdio bus.
This implementation should have the least changes on the
main dwmac logic but still serve the purpose for providing BSP callback
for any platform that needs to configure SERDES.

Voon Weifeng (1):
  net: stmmac: Enable SERDES power up/down sequence

 .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 171 ++++++++++++++++++
 .../net/ethernet/stmicro/stmmac/stmmac_main.c |  10 +
 include/linux/stmmac.h                        |   3 +
 3 files changed, 184 insertions(+)

-- 
2.17.1


             reply	other threads:[~2020-04-09 15:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 15:48 Voon Weifeng [this message]
2020-04-09 15:48 ` [RFC,net-next,v2, 1/1] net: stmmac: Enable SERDES power up/down sequence Voon Weifeng
2020-04-13 14:29   ` Jose Abreu
2020-04-14 16:44     ` Voon, Weifeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409154823.26480-1-weifeng.voon@intel.com \
    --to=weifeng.voon@intel.com \
    --cc=alexandre.torgue@st.com \
    --cc=andrew@lunn.ch \
    --cc=boon.leong.ong@intel.com \
    --cc=davem@davemloft.net \
    --cc=joabreu@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).