From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Matteo Croce <mcroce@redhat.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Luka Perkov <luka.perkov@sartura.hr>
Subject: Re: [PATCH net-next v2 3/3] net: phy: marvell10g: place in powersave mode at probe
Date: Fri, 10 Apr 2020 15:19:14 +0100 [thread overview]
Message-ID: <20200410141914.GY25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAGnkfhx+JkD6a_8ojU6tEL_vk6vtwQpxbwU9+beDepL4dxgLyQ@mail.gmail.com>
On Fri, Apr 10, 2020 at 03:48:34PM +0200, Matteo Croce wrote:
> On Fri, Apr 10, 2020 at 3:24 PM Russell King <rmk+kernel@armlinux.org.uk> wrote:
> >
> > Place the 88x3310 into powersaving mode when probing, which saves 600mW
> > per PHY. For both PHYs on the Macchiatobin double-shot, this saves
> > about 10% of the board idle power.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Hi,
>
> I have a Macchiatobin double shot, and my 10G ports stop working after
> this change.
> I reverted this commit on top of latest net-next and now the ports work again.
Please describe the problem in more detail.
Do you have the interface up? Does the PHY link with the partner?
Is the problem just that traffic isn't passed?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
next prev parent reply other threads:[~2020-04-10 14:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 15:53 [PATCH net-next v2 0/3] marvell10g tunable and power saving support Russell King - ARM Linux admin
2020-03-03 15:54 ` [PATCH net-next v2 1/3] net: phy: marvell10g: add mdix control Russell King
2020-03-03 17:03 ` Andrew Lunn
2020-03-03 19:06 ` Russell King - ARM Linux admin
2020-03-03 19:51 ` Andrew Lunn
2020-03-03 15:54 ` [PATCH net-next v2 2/3] net: phy: marvell10g: add energy detect power down tunable Russell King
2020-03-03 17:08 ` Andrew Lunn
2020-03-03 15:54 ` [PATCH net-next v2 3/3] net: phy: marvell10g: place in powersave mode at probe Russell King
2020-03-03 17:09 ` Andrew Lunn
2020-04-10 13:48 ` Matteo Croce
2020-04-10 14:19 ` Russell King - ARM Linux admin [this message]
2020-04-10 14:36 ` Russell King - ARM Linux admin
2020-04-10 14:39 ` Matteo Croce
2020-04-10 14:44 ` Russell King - ARM Linux admin
2020-04-10 14:50 ` Russell King - ARM Linux admin
2020-04-10 14:59 ` Matteo Croce
2020-04-10 15:16 ` Russell King - ARM Linux admin
2020-04-10 15:18 ` Matteo Croce
2020-04-10 16:04 ` Russell King - ARM Linux admin
2020-04-10 16:07 ` Matteo Croce
2020-04-10 16:23 ` Russell King - ARM Linux admin
2020-04-10 16:30 ` Matteo Croce
2020-04-10 17:10 ` Matteo Croce
2020-04-11 8:36 ` Russell King - ARM Linux admin
2020-04-14 16:30 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410141914.GY25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=luka.perkov@sartura.hr \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).