From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E4AC2BA2B for ; Fri, 10 Apr 2020 14:19:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DA4520692 for ; Fri, 10 Apr 2020 14:19:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ckhyBX3g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726654AbgDJOTf (ORCPT ); Fri, 10 Apr 2020 10:19:35 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:33736 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbgDJOTf (ORCPT ); Fri, 10 Apr 2020 10:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eOHDUBtktlAkp1IDj3ZDlz5cofiqpzly+S72LpriBqQ=; b=ckhyBX3gcnViqOVAYL/XXP0iU SvnqLVzNcNOQLM2++C59mDAKHtJ/9XOJaYu0EnsOOCHnEaodRtJTRlsyj/NGcBR5X7x7fUA5lzUIH EAAB5hRtvssDzRu/YqMFjxP7mGMc5iFNUS1TdZfcmyEtCVcOUTDHrh7FESk92kRWwNnwGnblRwXcc +/OBaTQDRW99nMBHfWbppMz3WYlCYtPK6Y4oM7MBTNWfk3pXhl4s/DlyY7/BMDLYbjBuei6u5z7uD JhsdqTmNoM3j6V/XFhKi0KYyzav5mPCFaqL6kTu55nXQRm+OVZPzRaYauRb+KjJW3txTZ5HXN9weZ qln67xsEw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48200) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jMuV6-0001uH-Ny; Fri, 10 Apr 2020 15:19:20 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jMuV0-0003qB-J5; Fri, 10 Apr 2020 15:19:14 +0100 Date: Fri, 10 Apr 2020 15:19:14 +0100 From: Russell King - ARM Linux admin To: Matteo Croce Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Antoine Tenart , "David S. Miller" , netdev , Luka Perkov Subject: Re: [PATCH net-next v2 3/3] net: phy: marvell10g: place in powersave mode at probe Message-ID: <20200410141914.GY25745@shell.armlinux.org.uk> References: <20200303155347.GS25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 10, 2020 at 03:48:34PM +0200, Matteo Croce wrote: > On Fri, Apr 10, 2020 at 3:24 PM Russell King wrote: > > > > Place the 88x3310 into powersaving mode when probing, which saves 600mW > > per PHY. For both PHYs on the Macchiatobin double-shot, this saves > > about 10% of the board idle power. > > > > Signed-off-by: Russell King > > Hi, > > I have a Macchiatobin double shot, and my 10G ports stop working after > this change. > I reverted this commit on top of latest net-next and now the ports work again. Please describe the problem in more detail. Do you have the interface up? Does the PHY link with the partner? Is the problem just that traffic isn't passed? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up