From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC13C2BA2B for ; Fri, 10 Apr 2020 15:16:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BE7820753 for ; Fri, 10 Apr 2020 15:16:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ekoM+suX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbgDJPQi (ORCPT ); Fri, 10 Apr 2020 11:16:38 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:34506 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbgDJPQi (ORCPT ); Fri, 10 Apr 2020 11:16:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vR72vmGCim9585VY+ScYOgvD+TBZdIjBLcrYr0gRvu4=; b=ekoM+suXaKg+5hUycRCufaoQX 1IVaxtlO85LVFs0OCIuQldpen/bZSVQOOHm5b2JbkTAx2LMqk435l6m6N15jts2VFR54m+aqdSIrw uygGTPCv1utUzTICSCDqELpbh9CLdRnjkbg2aJypEwJEpxAZToz3Vrd2zq3zpKgoe0ExAFsSjj1Dr ssYw2TbQUq6DmX7eFduq1UJ26CuMAbvTflR2YaIYmp1UssoATGpRsVYE1os8lEMkfeBa4beZh59xy BvHvZZxVGOFxNIk8k0UWKM0fmClMUH8DU35I1m61vzdKpzmVfAWfkxlAscZc2Dg0ozhvR9K4PC2R8 X0IlZIr+A==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:44084) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jMvOP-0002CQ-HY; Fri, 10 Apr 2020 16:16:29 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jMvON-0003tR-GA; Fri, 10 Apr 2020 16:16:27 +0100 Date: Fri, 10 Apr 2020 16:16:27 +0100 From: Russell King - ARM Linux admin To: Matteo Croce Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Antoine Tenart , "David S. Miller" , netdev , Luka Perkov Subject: Re: [PATCH net-next v2 3/3] net: phy: marvell10g: place in powersave mode at probe Message-ID: <20200410151627.GB25745@shell.armlinux.org.uk> References: <20200303155347.GS25745@shell.armlinux.org.uk> <20200410141914.GY25745@shell.armlinux.org.uk> <20200410143658.GM5827@shell.armlinux.org.uk> <20200410145034.GA25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 10, 2020 at 04:59:44PM +0200, Matteo Croce wrote: > On Fri, Apr 10, 2020 at 4:50 PM Russell King - ARM Linux admin > wrote: > > > > On Fri, Apr 10, 2020 at 04:39:48PM +0200, Matteo Croce wrote: > > > On Fri, Apr 10, 2020 at 4:37 PM Russell King - ARM Linux admin > > > wrote: > > > > > > > > On Fri, Apr 10, 2020 at 03:19:14PM +0100, Russell King - ARM Linux admin wrote: > > > > > On Fri, Apr 10, 2020 at 03:48:34PM +0200, Matteo Croce wrote: > > > > > > On Fri, Apr 10, 2020 at 3:24 PM Russell King wrote: > > > > > > > > > > > > > > Place the 88x3310 into powersaving mode when probing, which saves 600mW > > > > > > > per PHY. For both PHYs on the Macchiatobin double-shot, this saves > > > > > > > about 10% of the board idle power. > > > > > > > > > > > > > > Signed-off-by: Russell King > > > > > > > > > > > > Hi, > > > > > > > > > > > > I have a Macchiatobin double shot, and my 10G ports stop working after > > > > > > this change. > > > > > > I reverted this commit on top of latest net-next and now the ports work again. > > > > > > > > > > Please describe the problem in more detail. > > > > > > > > > > Do you have the interface up? Does the PHY link with the partner? > > > > > Is the problem just that traffic isn't passed? > > > > > > > > I've just retested on my Macchiatobin double shot, and it works fine. > > > > What revision PHYs do you have? Unfortunately, you can't read the > > > > PHY ID except using mii-diag: > > > > > > > > # mii-diag eth0 -p 32769 > > > > > > > > or > > > > > > > > # mii-diag eth1 -p 33025 > > > > > > > > Looking at word 3 and 4, it will be either: > > > > > > > > 002b 09aa > > > > 002b 09ab > > > > > > > > Thanks. > > > > > > > > -- > > > > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > > > > FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up > > > > > > > > > > > > > Hi Russel, > > > > > > I have the interface up connected via a DAC Cable to an i40e card. > > > When I set the link up I detect the carrier: > > > > > > mvpp2 f2000000.ethernet eth0: PHY [f212a600.mdio-mii:00] driver > > > [mv88x3310] (irq=POLL) > > > mvpp2 f2000000.ethernet eth0: configuring for phy/10gbase-r link mode > > > mvpp2 f2000000.ethernet eth0: Link is Up - 10Gbps/Full - flow control off > > > > > > No traffic is received or can be sent. > > > > I've just tried with a DAC cable ("Molex Inc. 74752-9542")... works for > > me: > > > > root@mcbin-ds:~# ip li set dev eth0 down > > mvpp2 f2000000.ethernet eth0: Link is Down > > root@mcbin-ds:~# ip li set dev eth0 up > > mvpp2 f2000000.ethernet eth0: PHY [f212a600.mdio-mii:00] driver [mv88x3310] (irq=POLL) > > mvpp2 f2000000.ethernet eth0: configuring for phy/10gbase-r link mode > > root@mcbin-ds:~# mvpp2 f2000000.ethernet eth0: Link is Up - 10Gbps/Full - flow control off > > IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready > > > > root@mcbin-ds:~# ping6 -I eth0 fe80::202:c9ff:fe54:d70a > > ping6: Warning: source address might be selected on device other than eth0. > > PING fe80::202:c9ff:fe54:d70a(fe80::202:c9ff:fe54:d70a) from :: eth0: 56 data bytes > > 64 bytes from fe80::202:c9ff:fe54:d70a%eth0: icmp_seq=1 ttl=64 time=0.344 ms > > 64 bytes from fe80::202:c9ff:fe54:d70a%eth0: icmp_seq=2 ttl=64 time=0.129 ms > > 64 bytes from fe80::202:c9ff:fe54:d70a%eth0: icmp_seq=3 ttl=64 time=0.118 ms > > ^C > > --- fe80::202:c9ff:fe54:d70a ping statistics --- > > 3 packets transmitted, 3 received, 0% packet loss, time 54ms > > rtt min/avg/max/mdev = 0.118/0.197/0.344/0.104 ms > > > > where fe80::202:c9ff:fe54:d70a is the IPv6 link local address on a > > Mellanox card in a different machine at the other end of the DAC > > cable. > > > > -- > > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > > FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up > > > > Hi Russel, > > that's it: > > # ./mii-diag eth0 -p 32769 > Using the specified MII PHY index 32769. > Basic registers of MII PHY #32769: 2040 0082 002b 09ab 0071 009a c000 0009. > Basic mode control register 0x2040: Auto-negotiation disabled, with > Speed fixed at 100 mbps, half-duplex. > Basic mode status register 0x0082 ... 0082. > Link status: not established. > *** Link Jabber! *** > Your link partner is generating 100baseTx link beat (no autonegotiation). > End of basic transceiver information. > > root@macchiatobin:~# ip link show dev eth0 > 2: eth0: mtu 1500 qdisc mq state UP > mode DEFAULT group default qlen 2048 > link/ether 00:51:82:11:22:00 brd ff:ff:ff:ff:ff:ff > > But no traffic in any direction So you have the same version PHY hardware as I do. So, we need further diagnosis, which isn't possible without a more advanced mii-diag tool - I'm sorting that out now, and will provide a link to a git repo later this afternoon. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up