From: Leon Romanovsky <leon@kernel.org>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net v1] net/sched: Don't print dump stack in event of transmission timeout
Date: Mon, 13 Apr 2020 13:20:53 +0300 [thread overview]
Message-ID: <20200413102053.GI334007@unreal> (raw)
In-Reply-To: <BN8PR12MB326678FFB34C9141AD73853BD3DD0@BN8PR12MB3266.namprd12.prod.outlook.com>
On Mon, Apr 13, 2020 at 09:01:32AM +0000, Jose Abreu wrote:
> From: Leon Romanovsky <leon@kernel.org>
> Date: Apr/12/2020, 07:08:54 (UTC+00:00)
>
> > [ 281.170584] ------------[ cut here ]------------
>
> Not objecting to the patch it-self (because usually stack trace is
> useless), but just FYI we use this marker in our CI to track for timeouts
> or crashes. I'm not sure if anyone else is using it.
I didn't delete the "NETDEV WATCHDOG .." message and it will be still
visible as a marker.
>
> And actually, can you please explain why BQL is not suppressing your
> timeouts ?
Driver can't distinguish between "real" timeout and "mixed traffic" timeout,
so we don't want to completely disable "dev->netdev_ops->ndo_tx_timeout(dev, i);"
call in watchdog [1]. The goal is to leave functionality in place and
simply remove stack trace to be similar to other BUG prints in that file [2].
[1] https://elixir.bootlin.com/linux/latest/source/net/sched/sch_generic.c#L444
[2] https://elixir.bootlin.com/linux/latest/source/net/sched/sch_generic.c#L328
>
> ---
> Thanks,
> Jose Miguel Abreu
next prev parent reply other threads:[~2020-04-13 10:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 6:08 [PATCH net v1] net/sched: Don't print dump stack in event of transmission timeout Leon Romanovsky
2020-04-12 18:59 ` Jakub Kicinski
2020-04-12 19:23 ` Leon Romanovsky
2020-04-13 4:19 ` David Miller
2020-04-13 5:03 ` Leon Romanovsky
2020-04-13 9:01 ` Jose Abreu
2020-04-13 10:20 ` Leon Romanovsky [this message]
2020-04-13 10:37 ` Jose Abreu
2020-04-13 10:54 ` Leon Romanovsky
2020-04-13 11:01 ` Jose Abreu
2020-04-13 11:25 ` Leon Romanovsky
2020-04-13 17:22 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413102053.GI334007@unreal \
--to=leon@kernel.org \
--cc=Jose.Abreu@synopsys.com \
--cc=arjan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).