From: Leon Romanovsky <leon@kernel.org>
To: Lauri Jakku <ljakku77@gmail.com>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
nic_swsd@realtek.com
Subject: Re: NET: r8168/r8169 identifying fix
Date: Mon, 13 Apr 2020 14:34:30 +0300 [thread overview]
Message-ID: <20200413113430.GM334007@unreal> (raw)
In-Reply-To: <dc2de414-0e6e-2531-0131-0f3db397680f@gmail.com>
On Mon, Apr 13, 2020 at 02:02:01PM +0300, Lauri Jakku wrote:
> Hi,
>
> Comments inline.
>
> On 2020-04-13 13:58, Leon Romanovsky wrote:
> > On Mon, Apr 13, 2020 at 01:30:13PM +0300, Lauri Jakku wrote:
> >> From 2d41edd4e6455187094f3a13d58c46eeee35aa31 Mon Sep 17 00:00:00 2001
> >> From: Lauri Jakku <lja@iki.fi>
> >> Date: Mon, 13 Apr 2020 13:18:35 +0300
> >> Subject: [PATCH] NET: r8168/r8169 identifying fix
> >>
> >> The driver installation determination made properly by
> >> checking PHY vs DRIVER id's.
> >> ---
> >> drivers/net/ethernet/realtek/r8169_main.c | 70 ++++++++++++++++++++---
> >> drivers/net/phy/mdio_bus.c | 11 +++-
> >> 2 files changed, 72 insertions(+), 9 deletions(-)
> >
> > I would say that most of the code is debug prints.
> >
>
> I tought that they are helpful to keep, they are using the debug calls, so
> they are not visible if user does not like those.
You are missing the point of who are your users.
Users want to have working device and the code. They don't need or like
to debug their kernel.
Thanks
next prev parent reply other threads:[~2020-04-13 11:35 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 10:30 NET: r8168/r8169 identifying fix Lauri Jakku
2020-04-13 10:58 ` Leon Romanovsky
2020-04-13 11:02 ` Lauri Jakku
2020-04-13 11:34 ` Leon Romanovsky [this message]
2020-04-13 11:46 ` Lauri Jakku
[not found] ` <d3adc7f2-06bb-45bc-ab02-3d443999cefd@gmail.com>
2020-04-15 16:18 ` Heiner Kallweit
[not found] ` <4860e57e-93e4-24f5-6103-fa80acbdfa0d@pp.inet.fi>
2020-04-16 18:26 ` Heiner Kallweit
2020-04-16 18:37 ` Lauri Jakku
2020-04-16 19:58 ` Lauri Jakku
2020-04-16 20:02 ` Heiner Kallweit
2020-04-16 20:10 ` Lauri Jakku
2020-04-16 20:38 ` Lauri Jakku
2020-04-16 20:50 ` Heiner Kallweit
2020-04-17 6:23 ` Lauri Jakku
2020-04-17 7:30 ` Lauri Jakku
2020-04-17 8:57 ` Heiner Kallweit
2020-04-18 11:06 ` Lauri Jakku
2020-04-18 18:46 ` Lauri Jakku
2020-04-19 15:09 ` Lauri Jakku
2020-04-19 16:49 ` Lauri Jakku
2020-04-19 16:00 ` Heiner Kallweit
2020-04-19 21:00 ` Lauri Jakku
2020-04-20 19:56 ` Lauri Jakku
2020-05-01 19:12 ` Lauri Jakku
2020-05-02 17:56 ` Lauri Jakku
2020-05-02 22:48 ` Lauri Jakku
[not found] ` <5cdc7f73-b109-2a37-8473-12889506b6a9@pp.inet.fi>
2020-05-02 23:15 ` Heiner Kallweit
2020-05-03 0:11 ` Lauri Jakku
2020-05-03 1:34 ` Lauri Jakku
2020-05-03 2:28 ` Lauri Jakku
2020-05-03 8:33 ` Heiner Kallweit
2020-05-03 13:54 ` Lauri Jakku
2020-05-19 5:15 ` Lauri Jakku
2020-05-11 13:09 ` Lauri Jakku
2021-03-11 16:00 ` gmail
2021-03-11 16:23 ` Heiner Kallweit
2021-03-11 16:43 ` gmail
2021-08-10 21:50 ` Late @ Gmail
2021-08-11 6:09 ` Heiner Kallweit
2021-08-11 13:17 ` Late @ Gmail
2021-08-11 19:47 ` Heiner Kallweit
2021-08-12 14:58 ` Late @ Gmail
2020-04-13 12:01 ` Lauri Jakku
2020-04-13 12:18 ` Leon Romanovsky
2020-04-13 14:44 ` Lauri Jakku
2020-04-13 15:33 ` Heiner Kallweit
2020-04-13 15:50 ` Lauri Jakku
2020-04-13 15:54 ` Heiner Kallweit
2020-04-13 16:10 ` Lauri Jakku
2020-04-13 16:17 ` Heiner Kallweit
2020-04-13 16:37 ` Lauri Jakku
2020-04-13 11:06 ` Lauri Jakku
2020-04-13 11:28 ` Heiner Kallweit
2020-04-13 11:40 ` Lauri Jakku
2020-04-13 11:57 ` Heiner Kallweit
2020-04-13 12:04 ` Lauri Jakku
-- strict thread matches above, loose matches on Subject: below --
2020-04-13 10:31 Lauri Jakku
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413113430.GM334007@unreal \
--to=leon@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=ljakku77@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).