From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EDD8C2BBC7 for ; Mon, 13 Apr 2020 11:35:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6379D2073E for ; Mon, 13 Apr 2020 11:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586777732; bh=g9GiP2ssoJe9E0aCBX9TGi5o6GBUAuGShYoolhAc1z4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Y/mZxkNNlvGxOORLnitwBQO0IKoytBTLPmJED49Nc2uINl63amlqkJrQpVXOU9cjM vdajUUW0DUNZTdzHN1t0yF6IKiEUlBXkM0pXLCujot24WaywXu3PA9RQ2oUEJ0q7lG /401w3tkMskuPwFFpwWaFO6uL4biDT0fnB7yXZ3w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729016AbgDMLee (ORCPT ); Mon, 13 Apr 2020 07:34:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:52858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727781AbgDMLee (ORCPT ); Mon, 13 Apr 2020 07:34:34 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F9DF20678; Mon, 13 Apr 2020 11:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586777673; bh=g9GiP2ssoJe9E0aCBX9TGi5o6GBUAuGShYoolhAc1z4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zP/NrWpsnobZvHgohl71Dc2HCMtuXVBEEkMHowUonBTGQeGADyHu+uu/beuu7wVvY 917Mk6+VLsuPhn8gkFISr8Z5WAPQkH4wv1IfTEab7LbbcVQM45qvEzBTMRMUxDOUBm hrBxJUzyf4ZWosS1QMFpHd+yHb73QVfkZ6CDwMY4= Date: Mon, 13 Apr 2020 14:34:30 +0300 From: Leon Romanovsky To: Lauri Jakku Cc: netdev@vger.kernel.org, Heiner Kallweit , nic_swsd@realtek.com Subject: Re: NET: r8168/r8169 identifying fix Message-ID: <20200413113430.GM334007@unreal> References: <4bc0fc0c-1437-fc41-1c50-38298214ec75@gmail.com> <20200413105838.GK334007@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 13, 2020 at 02:02:01PM +0300, Lauri Jakku wrote: > Hi, > > Comments inline. > > On 2020-04-13 13:58, Leon Romanovsky wrote: > > On Mon, Apr 13, 2020 at 01:30:13PM +0300, Lauri Jakku wrote: > >> From 2d41edd4e6455187094f3a13d58c46eeee35aa31 Mon Sep 17 00:00:00 2001 > >> From: Lauri Jakku > >> Date: Mon, 13 Apr 2020 13:18:35 +0300 > >> Subject: [PATCH] NET: r8168/r8169 identifying fix > >> > >> The driver installation determination made properly by > >> checking PHY vs DRIVER id's. > >> --- > >> drivers/net/ethernet/realtek/r8169_main.c | 70 ++++++++++++++++++++--- > >> drivers/net/phy/mdio_bus.c | 11 +++- > >> 2 files changed, 72 insertions(+), 9 deletions(-) > > > > I would say that most of the code is debug prints. > > > > I tought that they are helpful to keep, they are using the debug calls, so > they are not visible if user does not like those. You are missing the point of who are your users. Users want to have working device and the code. They don't need or like to debug their kernel. Thanks