From: Stephen Hemminger <stephen@networkplumber.org>
To: Petr Machata <petrm@mellanox.com>
Cc: netdev@vger.kernel.org, Xin Long <lucien.xin@gmail.com>,
William Tu <u9012063@gmail.com>
Subject: Re: [PATCH iproute2-next v2] ip: link_gre: Do not send ERSPAN attributes to GRE tunnels
Date: Mon, 13 Apr 2020 14:05:00 -0700 [thread overview]
Message-ID: <20200413140500.3a6d4bda@hermes.lan> (raw)
In-Reply-To: <d8dd14970b391c9c7e9ed11377d43dc56435eca5.1585954448.git.petrm@mellanox.com>
On Sat, 4 Apr 2020 01:55:34 +0300
Petr Machata <petrm@mellanox.com> wrote:
> In the commit referenced below, ip link started sending ERSPAN-specific
> attributes even for GRE and gretap tunnels. Fix by more carefully
> distinguishing between the GRE/tap and ERSPAN modes. Do not show
> ERSPAN-related help in GRE/tap mode, likewise do not accept ERSPAN
> arguments, or send ERSPAN attributes.
>
> Fixes: 83c543af872e ("erspan: set erspan_ver to 1 by default")
> Signed-off-by: Petr Machata <petrm@mellanox.com>
> Acked-by: William Tu <u9012063@gmail.com>
Applied, thanks for resending
prev parent reply other threads:[~2020-04-13 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 22:55 [PATCH iproute2-next v2] ip: link_gre: Do not send ERSPAN attributes to GRE tunnels Petr Machata
2020-04-13 21:05 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413140500.3a6d4bda@hermes.lan \
--to=stephen@networkplumber.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).