netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Andy Duan <fugang.duan@nxp.com>
Cc: David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Chris Healy <Chris.Healy@zii.aero>,
	Chris Heally <cphealy@gmail.com>
Subject: Re: [EXT] [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO
Date: Tue, 14 Apr 2020 14:55:33 +0200	[thread overview]
Message-ID: <20200414125533.GD611399@lunn.ch> (raw)
In-Reply-To: <VI1PR0402MB3600C15E60CB9436DFB59FCFFFDA0@VI1PR0402MB3600.eurprd04.prod.outlook.com>

> If we switch to polling mode, it is better to add usleep or cpu relax between IO
> Polling.

Hi Andy

Yes. I can do that. I've been wanting to try iopoll.h. I will see what
the performance impacts are.

> > I also have follow up patches which allows the bus to be run at higher speeds.
> > The Ethernet switch i have on the bus is happy to run a 5MHz rather than the
> > default 2.5MHz. 
> 
> Please compatible with 2.5Hz for your following patches.

Yes. I'm adding device tree properties. If the property is not
present, it will default to 2.5MHz. Same for preamble suppression, if
the boolean DT property is not present, it will not suppress it, so
keeping backwards compatibility.

	Andrew

  reply	other threads:[~2020-04-14 12:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14  0:45 [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO Andrew Lunn
2020-04-14  3:07 ` [EXT] " Andy Duan
2020-04-14  3:49   ` Andrew Lunn
2020-04-14  5:12     ` Andy Duan
2020-04-14 12:55       ` Andrew Lunn [this message]
2020-04-14 23:38 ` David Miller
2020-04-15  0:20   ` Andrew Lunn
2020-04-27 15:19 ` Leonard Crestez
2020-04-27 15:29   ` Andy Duan
2020-04-27 15:37   ` Andrew Lunn
2020-04-27 16:37   ` Andrew Lunn
2020-04-27 16:48     ` Fabio Estevam
2020-04-27 16:46   ` Andrew Lunn
2020-04-27 17:48     ` [EXT] " Andy Duan
2020-04-27 20:00     ` Leonard Crestez
2020-04-27 20:13       ` Andrew Lunn
2020-04-28  7:50         ` [EXT] " Andy Duan
2020-04-28 13:34           ` Andrew Lunn
2020-04-28 13:50             ` Andy Duan
2020-04-28 14:29               ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414125533.GD611399@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Chris.Healy@zii.aero \
    --cc=cphealy@gmail.com \
    --cc=davem@davemloft.net \
    --cc=fugang.duan@nxp.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).