From: Kalle Valo <kvalo@codeaurora.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: yhchuang@realtek.com, Kai-Heng Feng <kai.heng.feng@canonical.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org (open list:REALTEK WIRELESS
DRIVER (rtw88)),
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH v2] rtw88: Add delay on polling h2c command status bit
Date: Tue, 14 Apr 2020 15:07:28 +0000 (UTC) [thread overview]
Message-ID: <20200414150728.D6DA0C4478C@smtp.codeaurora.org> (raw)
In-Reply-To: <20200407073331.397-1-kai.heng.feng@canonical.com>
Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> On some systems we can constanly see rtw88 complains:
> [39584.721375] rtw_pci 0000:03:00.0: failed to send h2c command
>
> Increase interval of each check to wait the status bit really changed.
>
> Use read_poll_timeout() macro which fits anything we need here.
>
> Suggested-by: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
6343a6d4b213 rtw88: Add delay on polling h2c command status bit
--
https://patchwork.kernel.org/patch/11477667/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-04-14 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 7:33 [PATCH v2] rtw88: Add delay on polling h2c command status bit Kai-Heng Feng
2020-04-14 15:07 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414150728.D6DA0C4478C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).