From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49A7C2BB85 for ; Tue, 14 Apr 2020 16:31:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8729720678 for ; Tue, 14 Apr 2020 16:31:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="VrbNfrwu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391692AbgDNQaz (ORCPT ); Tue, 14 Apr 2020 12:30:55 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:44248 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391683AbgDNQar (ORCPT ); Tue, 14 Apr 2020 12:30:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bfBQPK6jHUP0T6D3BfvHJs65UU0jMBvVftwbQ7Ccv0A=; b=VrbNfrwuFd02NIyb8SgmA6cXs bvHoC4l9VPppfChhyDlv74mX1jH0buHsPPiGeFkFW087qAV/vkOnKuFd+ditPqCNsdsCrMBDz/Oeu DkYhXbu8i+lVtPUS+iy2IPBMxqzkfM+av6JIvX2U2l92tcypiIkD3ItnposiaxADUpBTjXGgD9oyr Y2htpGA0K+zpWj/LuW3+v7NAttyghVVpH33SGIshzpTk5sQhUf5KV6q4Lvd45270cYxOZO/ME373c LkdvqqMI8uUi/hEhURA5/tVGpm0tTr+igwVPgNrGUgkfJFepZUOcmQkeAdtUtsCncmrKMzYwF/xpL 2pNgd9CZg==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:45874) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jOOSF-0000h9-Pb; Tue, 14 Apr 2020 17:30:31 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jOOSA-0008Fc-I7; Tue, 14 Apr 2020 17:30:26 +0100 Date: Tue, 14 Apr 2020 17:30:26 +0100 From: Russell King - ARM Linux admin To: Matteo Croce , Andrew Lunn , Florian Fainelli , Heiner Kallweit Cc: Antoine Tenart , "David S. Miller" , netdev , Luka Perkov Subject: Re: [PATCH net-next v2 3/3] net: phy: marvell10g: place in powersave mode at probe Message-ID: <20200414163026.GW25745@shell.armlinux.org.uk> References: <20200303155347.GS25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 10, 2020 at 03:48:34PM +0200, Matteo Croce wrote: > On Fri, Apr 10, 2020 at 3:24 PM Russell King wrote: > > > > Place the 88x3310 into powersaving mode when probing, which saves 600mW > > per PHY. For both PHYs on the Macchiatobin double-shot, this saves > > about 10% of the board idle power. > > > > Signed-off-by: Russell King > > Hi, > > I have a Macchiatobin double shot, and my 10G ports stop working after > this change. > I reverted this commit on top of latest net-next and now the ports work again. For the public record, I've been debugging this in-part on Matteo's board, and it looks like it's a PHY firmware issue. Both my Macchiatobin boards use firmware 0.2.1.0 (which is not even mentioned on Marvell's extranet), whereas Matteo's board uses 0.3.3.0. It seems firmware 0.2.1.0 behaves "correctly" with my patch, but 0.3.3.0 does not - and neither does the latest 0.3.10.0. Both of these more recent versions seem to need a software reset to recover from power down mode... so a patch will be coming soon to add that. I also think it would be a good idea to print the PHY firmware version when the PHY is probed - another patch coming for that. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up