From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B00D7C2BA19 for ; Tue, 14 Apr 2020 17:26:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EF3520678 for ; Tue, 14 Apr 2020 17:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586885176; bh=CKkX3MgesuAwohWkS7pjImbdHGheMoo/wULg1HdG650=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TFktqTmBG+iqlNPlmFzwMFikumCzIy44V38A1xR4xvv4/ezVzCZvPC6a6fpLULU1N y9ArgCJwCtFFeuCwMOu23yPbkt4BHTkq8w1sMYZlE0KdcZ/5flcY6PWcODEYJMpO+f iCkkOR0yEp1isb9JVzIeEhN9h7drajw28vlD1cis= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407697AbgDNR0P (ORCPT ); Tue, 14 Apr 2020 13:26:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:59482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407592AbgDNR0I (ORCPT ); Tue, 14 Apr 2020 13:26:08 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F7CD20678; Tue, 14 Apr 2020 17:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586885168; bh=CKkX3MgesuAwohWkS7pjImbdHGheMoo/wULg1HdG650=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H83AFXS7TXgE23cvCAv0Xb81HXp31vYAtMjDgOVJjOxH/8EyyWZ4PLcmUFDYojigR x3DQTB2eV8wPyB50yUQr4IOMpChJr1PT/g1VxmpKUrrs8pL0ZigVeO6bDMEYv/PpiP 2XG0KiLtc0w2WGWnJR1qZOwrFkQcrV5THe9VEdfo= Date: Tue, 14 Apr 2020 20:26:04 +0300 From: Leon Romanovsky To: Borislav Petkov Cc: "David S . Miller" , Jakub Kicinski , Andy Gospodarek , Ion Badulescu , Jay Vosburgh , linux-pm@vger.kernel.org, netdev@vger.kernel.org, Pensando Drivers , Sebastian Reichel , Shannon Nelson , Veaceslav Falico Subject: Re: [PATCH net-next 1/4] drivers: Remove inclusion of vermagic header Message-ID: <20200414172604.GD1011271@unreal> References: <20200414155732.1236944-1-leon@kernel.org> <20200414155732.1236944-2-leon@kernel.org> <20200414160041.GG31763@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200414160041.GG31763@zn.tnic> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 14, 2020 at 06:00:41PM +0200, Borislav Petkov wrote: > On Tue, Apr 14, 2020 at 06:57:29PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Get rid of linux/vermagic.h includes, so that MODULE_ARCH_VERMAGIC from > > the arch header arch/x86/include/asm/module.h won't be redefined. > > > > In file included from ./include/linux/module.h:30, > > from drivers/net/ethernet/3com/3c515.c:56: > > ./arch/x86/include/asm/module.h:73: warning: "MODULE_ARCH_VERMAGIC" > > redefined > > 73 | # define MODULE_ARCH_VERMAGIC MODULE_PROC_FAMILY > > | > > In file included from drivers/net/ethernet/3com/3c515.c:25: > > ./include/linux/vermagic.h:28: note: this is the location of the > > previous definition > > 28 | #define MODULE_ARCH_VERMAGIC "" > > | > > > > Fixes: 6bba2e89a88c ("net/3com: Delete driver and module versions from 3com drivers") > > Signed-off-by: Borislav Petkov > > Just my SOB like that doesn't mean anything. You should add > > Co-developed-by: me > Signed-off-by: me > > if you want to state that we both worked on this fix. I personally don't use such notation and rely on the submission flow. The patch has two authors both written in SOBs and it will be visible in the git history that those SOBs are not maintainers additions. Can you please reply to the original patch with extra tags you want, so b4 and patchworks will pick them without me resending the patches? Thanks > > Thx. > > -- > Regards/Gruss, > Boris. > > SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg