From: Andrew Lunn <andrew@lunn.ch>
To: Robert Marko <robert.marko@sartura.hr>
Cc: f.fainelli@gmail.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
robh+dt@kernel.org, Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
devicetree@vger.kernel.org,
Christian Lamparter <chunkeey@gmail.com>,
Luka Perkov <luka.perkov@sartura.hr>
Subject: Re: [PATCH 1/3] net: phy: mdio: add IPQ40xx MDIO driver
Date: Tue, 14 Apr 2020 20:36:52 +0200 [thread overview]
Message-ID: <20200414183652.GB637127@lunn.ch> (raw)
In-Reply-To: <CA+HBbNE_-Pjr6dZ3qjgk1MiaT3PL9eUgs=XfK-ohkWDCR9yfZA@mail.gmail.com>
> Unfortunately, I don't have access to documentation and this is all based on
> GPL code from Qualcomm's SDK.
> So I don't really know whats their purpose.
Then please try to reverse engineer it. Just looking at the code, it
seems like one register is read, and the other is write. So use that
in the name.
> No, this is also an old relic from the SDK driver.
> It works without this perfectly fine, so I will drop it from v2.
Part of cleaning up 'Vendor Crap' is throwing out all the stuff like
this. What you end up with should be something you would of been happy
to write yourself.
> > Why the name am? Generally priv is used. I could also understand bus,
> > or even data, but am?
> Like most stuff in this driver, its a leftover from the SDK driver.
I guessed as much. But this is the sort of thing you need to fix when
cleaning up 'vendor crap'.
Andrew
prev parent reply other threads:[~2020-04-14 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 17:01 [PATCH 1/3] net: phy: mdio: add IPQ40xx MDIO driver Robert Marko
2020-04-13 17:01 ` [PATCH 2/3] dt-bindings: add Qualcomm IPQ4019 MDIO bindings Robert Marko
2020-04-13 17:01 ` [PATCH 3/3] dts: ipq4019: add MDIO node Robert Marko
2020-04-13 17:18 ` [PATCH 1/3] net: phy: mdio: add IPQ40xx MDIO driver Heiner Kallweit
2020-04-14 18:15 ` Robert Marko
2020-04-13 18:42 ` Andrew Lunn
2020-04-14 18:03 ` Robert Marko
2020-04-14 18:36 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414183652.GB637127@lunn.ch \
--to=andrew@lunn.ch \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chunkeey@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luka.perkov@sartura.hr \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).