From: Leon Romanovsky <leon@kernel.org>
To: Borislav Petkov <bp@suse.de>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jessica Yu <jeyu@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] kernel/module: Hide vermagic header file from general use
Date: Tue, 14 Apr 2020 21:41:55 +0300 [thread overview]
Message-ID: <20200414184155.GB1239315@unreal> (raw)
In-Reply-To: <20200414160349.GH31763@zn.tnic>
On Tue, Apr 14, 2020 at 06:03:50PM +0200, Borislav Petkov wrote:
> On Tue, Apr 14, 2020 at 06:57:32PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > VERMAGIC* definitions are not supposed to be used by the drivers,
>
> Yeah, this was only me conjecturing here. But yes, if people agree, this
> would be one way to do it.
>
> In any case and FWIW, series looks ok to me:
>
> Acked-by: Borislav Petkov <bp@suse.de>
Thanks, finally kbuild slap me to the face.
There is a need to change scripts/mod/modpost.c too and find the reason
why I didn't get any compilation errors.
<...>
>> drivers/gpio/gpio-aspeed.mod.c:3:10: fatal error: linux/vermagic.h: No such file or directory
3 | #include <linux/vermagic.h>
| ^~~~~~~~~~~~~~~~~~
compilation terminated.
<...>
>
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
prev parent reply other threads:[~2020-04-14 18:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 15:57 [PATCH net-next 0/4] Remove vermagic header from global include folder Leon Romanovsky
2020-04-14 15:57 ` [PATCH net-next 1/4] drivers: Remove inclusion of vermagic header Leon Romanovsky
2020-04-14 16:00 ` Borislav Petkov
2020-04-14 17:26 ` Leon Romanovsky
2020-04-14 17:44 ` Borislav Petkov
2020-04-14 17:54 ` Leon Romanovsky
2020-04-14 17:07 ` Sebastian Reichel
2020-04-14 17:32 ` Shannon Nelson
2020-04-14 17:45 ` Borislav Petkov
2020-04-14 15:57 ` [PATCH net-next 2/4] net/hns: Remove custom driver version in favour of global one Leon Romanovsky
2020-04-14 15:57 ` [PATCH net-next 3/4] net/nfp: Update driver to use global kernel version Leon Romanovsky
2020-04-14 20:37 ` Jakub Kicinski
[not found] ` <20200414155732.1236944-5-leon@kernel.org>
[not found] ` <20200414160349.GH31763@zn.tnic>
2020-04-14 18:41 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414184155.GB1239315@unreal \
--to=leon@kernel.org \
--cc=bp@suse.de \
--cc=davem@davemloft.net \
--cc=jeyu@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).