From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 429D3C2BA19 for ; Tue, 14 Apr 2020 18:42:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18BC820575 for ; Tue, 14 Apr 2020 18:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586889769; bh=92ouK1EZtTn+HmugH5BHACzd3FyOicJdIGabmG3nexM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FD1+Lj7z/tAr0c/Xf767W9kAnu4OJudiqoiKfPwd+/sgE/BBk7dg7MXFyhl6Nw5dw EYiVqeIJxRVgkS+NyYBVUlBS3ftstxFVT79U9/e1pVMPn9u3W7nlhpOqTwPrphXpf+ BJYEUPAtVDX3s4KNWKocBjGfApz8rgrEEXvXqxlk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504198AbgDNSmo (ORCPT ); Tue, 14 Apr 2020 14:42:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:38568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504162AbgDNSmB (ORCPT ); Tue, 14 Apr 2020 14:42:01 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 208EF2082E; Tue, 14 Apr 2020 18:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586889720; bh=92ouK1EZtTn+HmugH5BHACzd3FyOicJdIGabmG3nexM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X/xW7zelTwm+eLJXOa5oraSC7xyJEyB8ZvW05z0FCYozMYFK2a4FqfiL8E+EJkMkB tzcNKGEEUSG1tLaWK/VzGQ5Y/HiIgdk5/KCQRXyrNMe5mGfMX3siaXj3EZx3IpvQG7 qsUSEbcxeZQZQWaxbwHU10WBAXPtIii+L+vJqouE= Date: Tue, 14 Apr 2020 21:41:55 +0300 From: Leon Romanovsky To: Borislav Petkov Cc: "David S . Miller" , Jakub Kicinski , Jessica Yu , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 4/4] kernel/module: Hide vermagic header file from general use Message-ID: <20200414184155.GB1239315@unreal> References: <20200414155732.1236944-1-leon@kernel.org> <20200414155732.1236944-5-leon@kernel.org> <20200414160349.GH31763@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200414160349.GH31763@zn.tnic> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 14, 2020 at 06:03:50PM +0200, Borislav Petkov wrote: > On Tue, Apr 14, 2020 at 06:57:32PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > VERMAGIC* definitions are not supposed to be used by the drivers, > > Yeah, this was only me conjecturing here. But yes, if people agree, this > would be one way to do it. > > In any case and FWIW, series looks ok to me: > > Acked-by: Borislav Petkov Thanks, finally kbuild slap me to the face. There is a need to change scripts/mod/modpost.c too and find the reason why I didn't get any compilation errors. <...> >> drivers/gpio/gpio-aspeed.mod.c:3:10: fatal error: linux/vermagic.h: No such file or directory 3 | #include | ^~~~~~~~~~~~~~~~~~ compilation terminated. <...> > > Thx. > > -- > Regards/Gruss, > Boris. > > SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg