From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8BDBC2BA19 for ; Tue, 14 Apr 2020 18:49:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5EBE2074D for ; Tue, 14 Apr 2020 18:49:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Hr8ic4xo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504391AbgDNStG (ORCPT ); Tue, 14 Apr 2020 14:49:06 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37422 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504372AbgDNStD (ORCPT ); Tue, 14 Apr 2020 14:49:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OxNpUlNUMK2ThL4G37x7qilt6pOwxaWeKjcSrWQZuEU=; b=Hr8ic4xoLmRAc/SmERd5yeQF+U nVeHXZzHEWwXiRGSXCAyUUATS+Vq0N9LWfkWrKRCLDwobF1MrTUNT6MmIkKhp4+CDTVL5y8rXxSgL +kCxg2pVtKCW1ORV/g/6rIXP/ssFaqHzWO+sjSrr53Uq10aH6PBcDU3bJFxj7U3w/LL8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jOQcD-002i4U-RX; Tue, 14 Apr 2020 20:48:57 +0200 Date: Tue, 14 Apr 2020 20:48:57 +0200 From: Andrew Lunn To: Russell King Cc: Florian Fainelli , Heiner Kallweit , Matteo Croce , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net 2/2] net: marvell10g: soft-reset the PHY when coming out of low power Message-ID: <20200414184857.GE637127@lunn.ch> References: <20200414182935.GY25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 14, 2020 at 07:30:20PM +0100, Russell King wrote: > Soft-reset the PHY when coming out of low power mode, which seems to > be necessary with firmware versions 0.3.3.0 and 0.3.10.0. > > This depends on ("net: marvell10g: report firmware version") > > Fixes: c9cc1c815d36 ("net: phy: marvell10g: place in powersave mode at probe") > Reported-by: Matteo Croce > Tested-by: Matteo Croce > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew