From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Matteo Croce <mcroce@redhat.com>,
netdev@vger.kernel.org
Subject: [PATCH net v2 0/2] Fix 88x3310 leaving power save mode
Date: Tue, 14 Apr 2020 20:47:53 +0100 [thread overview]
Message-ID: <20200414194753.GB25745@shell.armlinux.org.uk> (raw)
Hi,
This series fixes a problem with the 88x3310 PHY on Macchiatobin
coming out of powersave mode noticed by Matteo Croce. It seems
that certain PHY firmwares do not properly exit powersave mode,
resulting in a fibre link not coming up.
The solution appears to be to soft-reset the PHY after clearing
the powersave bit.
We add support for reporting the PHY firmware version to the kernel
log, and use it to trigger this new behaviour if we have v0.3.x.x
or more recent firmware on the PHY. This, however, is a guess as
the firmware revision documentation does not mention this issue,
and we know that v0.2.1.0 works without this fix but v0.3.3.0 and
later does not.
drivers/net/phy/marvell10g.c | 36 +++++++++++++++++++++++++++++++++---
1 file changed, 33 insertions(+), 3 deletions(-)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
next reply other threads:[~2020-04-14 19:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 19:47 Russell King - ARM Linux admin [this message]
2020-04-14 19:49 ` [PATCH net v2 1/2] net: marvell10g: report firmware version Russell King
2020-04-14 19:52 ` Andrew Lunn
2020-04-14 21:06 ` Florian Fainelli
2020-04-14 19:49 ` [PATCH net v2 2/2] net: marvell10g: soft-reset the PHY when coming out of low power Russell King
2020-04-14 21:06 ` Florian Fainelli
2020-04-14 23:48 ` [PATCH net v2 0/2] Fix 88x3310 leaving power save mode David Miller
2020-05-08 21:32 ` Matteo Croce
2020-05-08 21:38 ` Russell King - ARM Linux admin
2020-05-09 6:36 ` Greg Kroah-Hartman
2020-05-09 7:32 ` Russell King - ARM Linux admin
2020-05-09 7:42 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414194753.GB25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).