From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC6CFC2BB85 for ; Wed, 15 Apr 2020 08:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B069206F9 for ; Wed, 15 Apr 2020 08:45:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="miSJwNAs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2894949AbgDOIpg (ORCPT ); Wed, 15 Apr 2020 04:45:36 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:36832 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2894936AbgDOIp1 (ORCPT ); Wed, 15 Apr 2020 04:45:27 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586940326; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=LLHAtAIAM78mFzS4R6StWkJhZeeVtwmJ8k6NH2UzjUQ=; b=miSJwNAs1akb0zHMhKW4wVlFRuLRTxKoqCjPsRE+vg/Kw991xlc6ES8QrHCO+Sf7M7rvWZ0F dXhcvPvcZlXqhr4IhBn3920+SMNjan5TpKllKxJa1qfTOA+aY0VcHKdZQRFCxk8972evAGzA 1rUAMltBfQoNiQTFiT0yM25K8Xs= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e96c993.7f622155a650-smtp-out-n01; Wed, 15 Apr 2020 08:45:07 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6D00FC433BA; Wed, 15 Apr 2020 08:45:07 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5264DC433CB; Wed, 15 Apr 2020 08:45:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5264DC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 5/9] brcmsmac: Add missing annotation for brcms_down() From: Kalle Valo In-Reply-To: <20200411001933.10072-6-jbi.octave@gmail.com> References: <20200411001933.10072-6-jbi.octave@gmail.com> To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "David S. Miller" , Johannes Berg , linux-wireless@vger.kernel.org (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), brcm80211-dev-list.pdl@broadcom.com (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), brcm80211-dev-list@cypress.com (open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER), netdev@vger.kernel.org (open list:NETWORKING DRIVERS) User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200415084507.6D00FC433BA@smtp.codeaurora.org> Date: Wed, 15 Apr 2020 08:45:07 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jules Irenge wrote: > Sparse reports a warning at brcms_down() > > warning: context imbalance in brcms_down() > - unexpected unlock > The root cause is the missing annotation at brcms_down() > Add the missing __must_hold(&wl->lock) annotation > > Signed-off-by: Jules Irenge Patch applied to wireless-drivers-next.git, thanks. 40fb232c02d1 brcmsmac: Add missing annotation for brcms_down() -- https://patchwork.kernel.org/patch/11483851/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches